Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] fabric_sql_database (return connection details) #280

Open
1 task done
garddolau opened this issue Mar 4, 2025 · 2 comments
Open
1 task done

[FEAT] fabric_sql_database (return connection details) #280

garddolau opened this issue Mar 4, 2025 · 2 comments
Labels
feature New feature or request

Comments

@garddolau
Copy link

🚀 Feature description

Great to get the ability to deploy a fabric_sql_database but to make it useful to downstream terraform config it would be great if it returned the connection details for the created database (similar to how fabric_warehouse does).

Something like below in the state maybe

      "instances": [
        {
          "schema_version": 0,
          "attributes": {
            "description": "example",
            "display_name": "sql_example",
            "id": "f852eea4-e36c-4590-8b36-20569cae7fb8",
            "timeouts": null,
            "workspace_id": "c4ddf736-752f-4a03-8970-399d969d4c4a",
	    "properties": {
              "server_name": "dqjx2zrgh4uejnetrut54cdkau-g3353rbpoubuvclqhgoznhkmji.database.fabric.microsoft.com",
              "database_name": "sql_example-f852eea4-e36c-4590-8b36-20569cae7fb8"
            },
          },
          "sensitive_attributes": []
        }
      ]

🔈 Motivation

In order by create downstream terraform config eg, add connection details to key vault we need the fabric_sql_database create to return to server_name & the database_name

🛰 Alternatives

We can get:
database_name via a concat of display_name and id
server_name via a warehouse create output and swapping .datawarehouse.fabric.microsoft.com with .database.fabric.microsoft.com

Neither are ideal though

🚧 Potential Configuration / Desired Solution

Output similar to below

      "instances": [
        {
          "schema_version": 0,
          "attributes": {
            "description": "example",
            "display_name": "sql_example",
            "id": "f852eea4-e36c-4590-8b36-20569cae7fb8",
            "timeouts": null,
            "workspace_id": "c4ddf736-752f-4a03-8970-399d969d4c4a",
	    "properties": {
              "server_name": "dqjx2zrgh4uejnetrut54cdkau-g3353rbpoubuvclqhgoznhkmji.database.fabric.microsoft.com",
              "database_name": "sql_example-f852eea4-e36c-4590-8b36-20569cae7fb8"
            },
          },
          "sensitive_attributes": []
        }
      ]

📎 Additional context

No response

☑️ Acceptance Criteria

Once a fabric_sql_database is deployed we can get its server_name & database_name

🔰 Code of Conduct

  • I agree to follow this project's Code of Conduct.
@garddolau garddolau added the feature New feature or request label Mar 4, 2025
@DariuszPorowski
Copy link
Member

Hi @garddolau Thanks for sharing this idea.

@cisraeli @badeamarjieh @OrBaubergMicrosoft @Halamish51
May you check with SQL DB team if they have any plans (if yes, then what is ETA) to onboard properties to SQL Database API for Get and List operations?

@garddolau
Copy link
Author

Hi @DariuszPorowski thanks for reply.

Do you know anyway I can log feature requests with the Fabric Rest API team?
I can log on the Fabric Ideas portal but not quite the same as logging direct with the team via github or something similar.

Cheers,
Darren

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants