[RS] Add GitHub Support to fabric_workspace_git

[SemUijen]

🚀 Feature description

Adding support for GitHub for the fabric_workspace_git resource.

1. As git_provider_type
   • Add Github Provider details inputs (https://learn.microsoft.com/en-us/rest/api/fabric/core/git/connect?tabs=HTTP#githubdetails)
   • git_provider_details: Required schema attributes should the be based on chosen git_provider_type

🔈 Motivation

Currently only AzureDevOps is supported #108 . For us it is a standard way of working to use Github and for some of our clients its a must.

🛰 Alternatives

A second approach to add GitHub support is to have separate resources for github and Azure Devops

🚧 Potential Configuration / Desired Solution

Option 1:

resource "fabric_workspace_git" "example" {
  workspace_id            = "id"
  initialization_strategy = ""
  git_provider_details = {
    git_provider_type = "GitHub"
    repository_name   = "example"
    branch_name       = "example"
    directory_name    = "example"
    owner_name = "example"
  }
}

or
Option 1:

resource "fabric_workspace_github" "example" {
  workspace_id            = "id"
  initialization_strategy = ""
  git_provider_details = {
    repository_name   = "example"
    branch_name       = "example"
    directory_name    = "example"
    owner_name = "example"
  }
}

📎 Additional context

I saw that contribution(PRs) currently won't be accepted. Is this feature by any chance already in development? otherwise I would like to add it myself if possible 😄

🔰 Code of Conduct

• I agree to follow this project's Code of Conduct.

[DariuszPorowski]

Hi @SemUijen

GitHub integration API uses "connection ID" based on Connections API (https://learn.microsoft.com/en-us/rest/api/fabric/core/connections), so adding this resource requires connection resource implementation in the Provider first as a dependency.

Connections API is in preview, and that blocks us to onboard to the Provider - currently, only APIs that are GA will be added on an ongoing basis. Once Connections API gets GA, we will start working on the connection resource which will unlock the addition of GitHub.

[SemUijen]

Hi @DariuszPorowski It makes sense that you are not implementing non-GA APIs. Do you have an idea of when these APIs will be GA?
Will this be Q1 or later?

[DariuszPorowski]

@SemUijen ETA unknown for now, especially Connections API has been released as Public Preview ~1 mo ago, so do not expect to have GA in Q1 in that short period of time.

[SemUijen]

@DariuszPorowski Thx for quick update! I will build a temporary solution for now 😄

[decodingahmed]

Hey @DariuszPorowski, I believe that the Git integration uses a different API (Connect API instead of Connections API) to connect GitHub. This API appears to be GA: https://learn.microsoft.com/en-us/rest/api/fabric/core/git/connect?tabs=HTTP

Happy to help with contributing to this, if it helps 👍🏽

Hey @SemUijen, would you be able to share what you did in the mean time? Would appreciate some other ideas too, but I was thinking about one of the following options:

1. Use Terraform's http provider to make the call but there's a whole auth token song and dance I need to do before that.
2. Use a null_resource and call a python or shell command (curl, probably) inside.

[DariuszPorowski]

Hi @decodingahmed GitHub uses Connection ID from Connections API as part of Git connect API payload. Connections API is still in preview, but terraform work for Connections has been started already, initial ETA is end of March. After that we can start designing GitHub resource.