Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution filter file support #172

Open
ViktorHofer opened this issue Sep 27, 2020 · 2 comments
Open

Solution filter file support #172

ViktorHofer opened this issue Sep 27, 2020 · 2 comments
Labels
feature request New feature or enhancement help wanted Looking for community contributions!

Comments

@ViktorHofer
Copy link
Member

It would be great if slngen would support solution filter file as an output as well (slnfgen 😁). That would help with only having a single repo wide solution file and per leaf solution filter files that reference the solution file.

@jeffkl
Copy link
Collaborator

jeffkl commented Sep 28, 2020

I had started working on this a while back: https://github.com/microsoft/slngen/blob/master/src/Microsoft.VisualStudio.SlnGen/SlnfFile.cs

Its a little complicated because how solution filters work. Essentially you'd need a single SLN file at the root of the repo that contains every project and an SLNF file in the current directory that contains just the projects you care about. Then you'd have to check in the SLN file so that the solution GUID doesn't change. As you generate solution filters, you'd get the caching from VS (as long as you don't delete the .vs folder from the root of your repo). And if the solution filter contained a project that wasn't in the SLN file, that would need to be constantly updated.

In the end I decided it didn't really make sense and the benefits seemed very small. Generating solution files on the fly "just works" without the complications. What are your thoughts?

@ViktorHofer
Copy link
Member Author

Generating solution files on the fly "just works" without the complications. What are your thoughts?

We probably want to continue checking in our sln/slnf files in the project leafs as the Developer Command Prompt requirement and cross-plat limitation is problematic. Continue checking the slns in isn't much of a problem but in an ideal world we would replace them with slnfs for the sake of sanity (the dark path - using slns and seeing all these GUIDs - disturbs my inner peace 😁).

@jeffkl jeffkl added feature request New feature or enhancement help wanted Looking for community contributions! labels Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or enhancement help wanted Looking for community contributions!
Projects
None yet
Development

No branches or pull requests

2 participants