From 5cac174f4a7dba1373233d10c2c1de484f4b21b3 Mon Sep 17 00:00:00 2001
From: thsparks <thsparks@microsoft.com>
Date: Fri, 7 Mar 2025 12:54:36 -0800
Subject: [PATCH 1/9] Use foreground color for buttons in the common editor
 toggle. This is generally up against a slightly faded background, in which
 case foreground is going to be the most visible. Fixes an issue in the share
 -> embed toggle.

---
 react-common/styles/controls/EditorToggle.less | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/react-common/styles/controls/EditorToggle.less b/react-common/styles/controls/EditorToggle.less
index ad724bcbf649..e1b973acd14d 100644
--- a/react-common/styles/controls/EditorToggle.less
+++ b/react-common/styles/controls/EditorToggle.less
@@ -37,7 +37,7 @@
 
     & > .common-button {
         background: none;
-        color: var(--pxt-neutral-background1);
+        color: var(--pxt-neutral-foreground1);
         transition: color .25s;
         margin: 0;
         width: 100%;

From e0c8268566a1d9b3204ad311ecc61a2cb5720be3 Mon Sep 17 00:00:00 2001
From: thsparks <thsparks@microsoft.com>
Date: Fri, 7 Mar 2025 13:14:45 -0800
Subject: [PATCH 2/9] Fix foreground for extension card "extra content" (which
 to my knowledge, is only used for user-provided extension disclaimer.

---
 react-common/styles/extensions/ExtensionCard.less | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/react-common/styles/extensions/ExtensionCard.less b/react-common/styles/extensions/ExtensionCard.less
index 26071e77451d..2eca0873055d 100644
--- a/react-common/styles/extensions/ExtensionCard.less
+++ b/react-common/styles/extensions/ExtensionCard.less
@@ -51,7 +51,7 @@
         border-top: solid 1px var(--pxt-neutral-stencil1);
         flex-shrink: 0;
         font-size: 16px;
-        color: var(--pxt-secondary-background);
+        color: var(--pxt-neutral-foreground1);
 
         overflow: hidden;
         border-bottom-left-radius: 0.5rem;

From 2f4b75c1db6b68d23cb03ffc52485c8ff544971a Mon Sep 17 00:00:00 2001
From: thsparks <thsparks@microsoft.com>
Date: Fri, 7 Mar 2025 13:43:38 -0800
Subject: [PATCH 3/9] Add alpha 80 and use for foreground of card description
 content.

---
 react-common/styles/theming/base-theme.less | 1 +
 theme/color-themes/high-contrast.json       | 1 +
 theme/semantic-ui-overrides.less            | 2 +-
 3 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/react-common/styles/theming/base-theme.less b/react-common/styles/theming/base-theme.less
index 0bfdd5209e63..39ecf5de3ab4 100644
--- a/react-common/styles/theming/base-theme.less
+++ b/react-common/styles/theming/base-theme.less
@@ -65,6 +65,7 @@
     --pxt-neutral-alpha10: rgba(0, 0, 0, 0.1);
     --pxt-neutral-alpha20: rgba(0, 0, 0, 0.2);
     --pxt-neutral-alpha50: rgba(0, 0, 0, 0.5);
+    --pxt-neutral-alpha80: rgba(0, 0, 0, 0.8);
 
     --pxt-link: #3977B4;
     --pxt-link-hover: #204467;
diff --git a/theme/color-themes/high-contrast.json b/theme/color-themes/high-contrast.json
index beeaf3924832..febcfcd07ac6 100644
--- a/theme/color-themes/high-contrast.json
+++ b/theme/color-themes/high-contrast.json
@@ -73,6 +73,7 @@
         "pxt-neutral-alpha10": "rgba(255, 255, 255, 0.1)",
         "pxt-neutral-alpha20": "rgba(255, 255, 255, 0.2)",
         "pxt-neutral-alpha50": "rgba(255, 255, 255, 0.5)",
+        "pxt-neutral-alpha80": "rgba(255, 255, 255, 0.8)",
 
         "pxt-link": "#807FFF",
         "pxt-link-hover": "#1b19ff",
diff --git a/theme/semantic-ui-overrides.less b/theme/semantic-ui-overrides.less
index 901f9e8b3288..f0c61987b638 100644
--- a/theme/semantic-ui-overrides.less
+++ b/theme/semantic-ui-overrides.less
@@ -82,7 +82,7 @@ body.pxt-theme-root {
             }
     
             .description {
-                color: var(--pxt-neutral-alpha50);
+                color: var(--pxt-neutral-alpha80);
             }
         }
 

From 88bfd9f2cea381cd72a89c481e678ef82d47b49b Mon Sep 17 00:00:00 2001
From: thsparks <thsparks@microsoft.com>
Date: Fri, 7 Mar 2025 14:46:16 -0800
Subject: [PATCH 4/9] Remove inverted class from new asset buttons. They aren't
 needed since both foreground and background get set anyway (and they're
 causing the colors to get overriden in dark theme)

---
 webapp/src/components/assetEditor/assetGallery.tsx | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/webapp/src/components/assetEditor/assetGallery.tsx b/webapp/src/components/assetEditor/assetGallery.tsx
index dc354fa5ced5..6e7f9763fbfb 100644
--- a/webapp/src/components/assetEditor/assetGallery.tsx
+++ b/webapp/src/components/assetEditor/assetGallery.tsx
@@ -121,7 +121,7 @@ class AssetGalleryImpl extends React.Component<AssetGalleryProps, AssetGallerySt
             <AssetTopbar />
             <div className={`asset-editor-card-list ${view !== GalleryView.User ? "hidden" : ""}`}>
                 <AssetCardList assets={filterAssets(userAssets, isBlocksProject)}>
-                    <Button className="create-new inverted"
+                    <Button className="create-new"
                         disabled={disableCreateButton}
                         leftIcon="icon huge add circle"
                         title={lf("Create a new asset")}
@@ -142,7 +142,7 @@ class AssetGalleryImpl extends React.Component<AssetGalleryProps, AssetGallerySt
                     this.assetCreateOptions.map((opt, i) => {
                         return <Button
                             key={i}
-                            className="asset-editor-create-button inverted"
+                            className="asset-editor-create-button"
                             leftIcon={`icon ${opt.icon}`}
                             label={opt.label}
                             title={lf("Create a new {0} asset", opt.label)}

From f91d55ae4d2c8cea100e73f58ee177c9637300ce Mon Sep 17 00:00:00 2001
From: thsparks <thsparks@microsoft.com>
Date: Fri, 7 Mar 2025 14:52:20 -0800
Subject: [PATCH 5/9] Theme report abuse text inputs

---
 theme/semantic-ui-overrides.less | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/theme/semantic-ui-overrides.less b/theme/semantic-ui-overrides.less
index f0c61987b638..9c5d7aa99f21 100644
--- a/theme/semantic-ui-overrides.less
+++ b/theme/semantic-ui-overrides.less
@@ -173,7 +173,9 @@ body.pxt-theme-root {
         color: var(--pxt-neutral-foreground2);
     }
 
-    .ui.input {
+    .ui.input,
+    .ui.form input[type=url],
+    .ui.form textarea {
         background: none;
         color: var(--pxt-neutral-foreground2);
 

From 90118f5e26f859c811ae39496a4f042f41a2371f Mon Sep 17 00:00:00 2001
From: thsparks <thsparks@microsoft.com>
Date: Fri, 7 Mar 2025 15:11:01 -0800
Subject: [PATCH 6/9] Fix borders on tables (noticeable in the all projects
 table view)

---
 theme/semantic-ui-overrides.less | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/theme/semantic-ui-overrides.less b/theme/semantic-ui-overrides.less
index 9c5d7aa99f21..2dbcf2c05f30 100644
--- a/theme/semantic-ui-overrides.less
+++ b/theme/semantic-ui-overrides.less
@@ -115,6 +115,7 @@ body.pxt-theme-root {
     .ui.table {
         color: var(--pxt-neutral-foreground1);
         background: var(--pxt-neutral-background1);
+        border: 1px solid var(--pxt-neutral-alpha20);
 
         th, tr, i {
             color: var(--pxt-neutral-foreground1);
@@ -129,6 +130,20 @@ body.pxt-theme-root {
                 }
             }
         }
+
+        tr, th {
+            border-bottom: 1px solid var(--pxt-neutral-alpha10);
+        }
+
+        tr td {
+            border-top: 1px solid var(--pxt-neutral-alpha10);
+        }
+
+        td:nth-child(2),
+        tfoot:not(.full-width) th:nth-child(2),
+        thead:not(.full-width) th:nth-child(2) {
+            border-left: 1px solid var(--pxt-neutral-alpha10);
+        }
     }
 
     .ui.header {

From e50f6edb6c46098489d8244defe983a32464991b Mon Sep 17 00:00:00 2001
From: thsparks <thsparks@microsoft.com>
Date: Fri, 7 Mar 2025 15:19:18 -0800
Subject: [PATCH 7/9] Better separation from background for settings menu

---
 theme/semantic-ui-overrides.less | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/theme/semantic-ui-overrides.less b/theme/semantic-ui-overrides.less
index 2dbcf2c05f30..2ef22ec6d28b 100644
--- a/theme/semantic-ui-overrides.less
+++ b/theme/semantic-ui-overrides.less
@@ -162,7 +162,8 @@ body.pxt-theme-root {
         .dropdown.item .menu, .ui.dropdown .menu {
             background: var(--pxt-neutral-background1);
             color: var(--pxt-neutral-foreground1);
-            box-shadow: 0 1px 3px 0 var(--pxt-neutral-alpha10);
+            box-shadow: 0 1px 3px 0 var(--pxt-neutral-alpha20);
+            border: 1px solid var(--pxt-neutral-stencil1);
 
             .item {
                 color: var(--pxt-neutral-foreground1) !important; // override !important in semantic ui

From 5e57554b8838b5a5302243837d911aec0bb0b322 Mon Sep 17 00:00:00 2001
From: thsparks <thsparks@microsoft.com>
Date: Fri, 7 Mar 2025 15:37:45 -0800
Subject: [PATCH 8/9] Theme blockly context menu

---
 theme/blockly-core.less | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/theme/blockly-core.less b/theme/blockly-core.less
index 049d22792938..db46594bf278 100644
--- a/theme/blockly-core.less
+++ b/theme/blockly-core.less
@@ -306,8 +306,10 @@ text.blocklyCheckbox {
 *******************************/
 
 .blocklyWidgetDiv .blocklyContextMenu {
-    border: 1px solid rgba(34,36,38,.15);
-    box-shadow: 0 1px 2px 0 rgba(34,36,38,.15) !important;
+    background: var(--pxt-neutral-background1);
+    color: var(--pxt-neutral-foreground1);
+    border: 1px solid var(--pxt-neutral-stencil1);
+    box-shadow: 0 1px 2px 0 var(--pxt-neutral-alpha20) !important;
     padding: 0 !important;
 }
 
@@ -315,12 +317,15 @@ text.blocklyCheckbox {
     margin: 0 !important;
     padding: .92857143em 1.14285714em !important;
     font: normal 13px @pageFont !important;
+    background: var(--pxt-neutral-background1);
+    color: var(--pxt-neutral-foreground1);
 }
 
 .blocklyWidgetDiv .blocklyContextMenu .goog-menuitem-highlight, .blocklyWidgetDiv .blocklyContextMenu .goog-menuitem-hover {
     border: none !important;
     padding: .92857143em 1.14285714em !important;
-    background: rgba(0,0,0,.05) !important;
+    background: var(--pxt-neutral-background1-hover) !important;
+    color: var(--pxt-neutral-foreground1-hover);
 }
 
 /*******************************

From 902f9cf3fbc3340067f0f60f64e724b7fb12496a Mon Sep 17 00:00:00 2001
From: thsparks <thsparks@microsoft.com>
Date: Fri, 7 Mar 2025 16:16:02 -0800
Subject: [PATCH 9/9] Fix download ... menu colors

---
 theme/common.less | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/theme/common.less b/theme/common.less
index d507ca99fb10..4a8804994aa7 100644
--- a/theme/common.less
+++ b/theme/common.less
@@ -634,6 +634,21 @@ div.simframe > iframe {
     position: relative;
 }
 
+.hw-button.ui.dropdown .menu  {
+    background: var(--pxt-neutral-background1);
+    color: var(--pxt-neutral-foreground1);
+    border: 1px solid var(--pxt-neutral-stencil1);
+
+    & > .item {
+        color: var(--pxt-neutral-foreground1);
+
+        &:hover, &:focus {
+            background: var(--pxt-neutral-background1-hover);
+            color: var(--pxt-neutral-foreground1-hover);
+        }
+    }
+}
+
 .ui.button:hover,
 .ui.button:focus {
     filter: grayscale(.15) brightness(.85) contrast(1.3);