Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: AdvLoggerPkg and probably other are not built for AARCH64 in CI #434

Closed
1 task done
cfernald opened this issue Feb 7, 2024 · 2 comments
Closed
1 task done

[Bug]: AdvLoggerPkg and probably other are not built for AARCH64 in CI #434

cfernald opened this issue Feb 7, 2024 · 2 comments
Assignees
@cfernald
Labels
state:stale Has not been updated in a long time type:bug Something isn't working urgency:medium Important with a moderate impact

Comments

@cfernald
Copy link
Contributor

cfernald commented Feb 7, 2024

Is there an existing issue for this?

  • I have searched existing issues

Current Behavior

Currently AdvLoggerPkg and probably others are not built in CI with AARCH64 because of the SUPPORTED_ARCHITECTURES, despite having AARCH64 specific code that needs CI.

Expected Behavior

Package that are used for AARCH64 should have CI builds.

Steps To Reproduce

N/A

Build Environment

- OS(s): Ubuntu
- Tool Chain(s): GCC
- Targets Impacted: CI

Version Information

N/A

Urgency

Medium

Are you going to fix this?

I will fix it

Do you need maintainer feedback?

No maintainer feedback needed

Anything else?

No response
@cfernald cfernald added type:bug Something isn't working state:needs-triage Needs to triaged to determine next steps labels Feb 7, 2024
@github-actions github-actions bot added the urgency:medium Important with a moderate impact label Feb 7, 2024
@cfernald cfernald removed the state:needs-triage Needs to triaged to determine next steps label Feb 7, 2024
@cfernald cfernald mentioned this issue Feb 7, 2024
Merged
5 tasks
cfernald added a commit that referenced this issue Feb 9, 2024
@cfernald
Switch MmCoreArm advanced logger to use updated MMU functions (#435)
9855702 
## Description

As part of 202311, ArmMmuLib switched to use ArmSetMemoryAttributes
instead of the individual set/clear routines. This was also implemented
in the MU change to converge ArmMmuStandaloneMmLib's use with ArmMmuLib.
This changed fixes MmCoreArm/AdvancedLoggerLib.c to use the updated
functions.

It seems this went unnoticed originally due to issue #434 

- [x] Impacts functionality?
- [ ] Impacts security?
- [ ] Breaking change?
- [ ] Includes tests?
- [ ] Includes documentation?

## How This Was Tested

Manually tested.

## Integration Instructions

N/A
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has not had activity in 45 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the state:stale Has not been updated in a long time label Mar 23, 2024
@github-actions GitHub Actions
Copy link

This issue has been automatically been closed because it did not have any activity in 45 days and no follow up within 7 days after being marked stale. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cfernald cfernald

Labels
state:stale Has not been updated in a long time type:bug Something isn't working urgency:medium Important with a moderate impact
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cfernald