From f4ff7c767194abeb641f76c5124cd5fe584a2464 Mon Sep 17 00:00:00 2001 From: Daniel Madrid Date: Mon, 3 Mar 2025 12:39:10 -0800 Subject: [PATCH 1/8] fix condition when running copyresults --- tools/pipelines/templates/build-npm-client-package.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/pipelines/templates/build-npm-client-package.yml b/tools/pipelines/templates/build-npm-client-package.yml index 57d1f7d2ed11..8e26d5bcebf3 100644 --- a/tools/pipelines/templates/build-npm-client-package.yml +++ b/tools/pipelines/templates/build-npm-client-package.yml @@ -608,7 +608,7 @@ extends: - task: Npm@1 displayName: 'npm run test:copyresults' - condition: and(succeededOrFailed(), eq(variables['startTest'], 'true')) + condition: eq(variables['startTest'], 'true') inputs: command: custom workingDir: '${{ parameters.buildDirectory }}' From 525eeae51b499091a760656be3cc3ce1b940f1d4 Mon Sep 17 00:00:00 2001 From: Daniel Madrid Date: Mon, 3 Mar 2025 12:45:38 -0800 Subject: [PATCH 2/8] fake error --- .../devtools-view/src/test/DynamicComposedChart.test.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/tools/devtools/devtools-view/src/test/DynamicComposedChart.test.tsx b/packages/tools/devtools/devtools-view/src/test/DynamicComposedChart.test.tsx index 1fad4421ab47..e65c60960407 100644 --- a/packages/tools/devtools/devtools-view/src/test/DynamicComposedChart.test.tsx +++ b/packages/tools/devtools/devtools-view/src/test/DynamicComposedChart.test.tsx @@ -75,7 +75,7 @@ describe("DynamicComposedChart component test", () => { test("renders without crashing with data", () => { render(); const dynamicComposedChartElement = screen.findByTestId("test-dynamic-composed-chart"); - expect(dynamicComposedChartElement).not.toBeNull(); + expect(dynamicComposedChartElement).toBeNull(); expect(dynamicComposedChartElement).toBeDefined(); }); From 64c57cdaad71f99abf1c1ab2c389b3f383753e3f Mon Sep 17 00:00:00 2001 From: Daniel Madrid Date: Mon, 3 Mar 2025 13:15:04 -0800 Subject: [PATCH 3/8] condition in non coverage copyresults; reference to start test variable --- tools/pipelines/templates/build-npm-client-package.yml | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tools/pipelines/templates/build-npm-client-package.yml b/tools/pipelines/templates/build-npm-client-package.yml index 8e26d5bcebf3..bf897917d5c3 100644 --- a/tools/pipelines/templates/build-npm-client-package.yml +++ b/tools/pipelines/templates/build-npm-client-package.yml @@ -596,7 +596,8 @@ extends: # Set variable startTest if everything is good so far and we'll start running tests, # so that the steps to process/upload test coverage results only run if we got to the point of actually running tests. - script: | - echo "##vso[task.setvariable variable=startTest]true" + echo "##vso[task.setvariable variable=startTest;isOutput=true]true" + name: SetStartTestCoverage displayName: Start Test - ${{ each test in parameters.coverageTests }}: @@ -608,7 +609,7 @@ extends: - task: Npm@1 displayName: 'npm run test:copyresults' - condition: eq(variables['startTest'], 'true') + condition: and(succeededOrFailed(), eq(variables['SetStartTestCoverage.startTest'], 'true')) inputs: command: custom workingDir: '${{ parameters.buildDirectory }}' @@ -750,7 +751,8 @@ extends: # Set variable startTest if everything is good so far and we'll start running tests, # so that the steps to process/upload test coverage results only run if we got to the point of actually running tests. - script: | - echo "##vso[task.setvariable variable=startTest]true" + echo "##vso[task.setvariable variable=startTest;isOutput=true]true" + name: SetStartTest displayName: Start Test - template: /tools/pipelines/templates/include-test-task.yml@self @@ -761,6 +763,7 @@ extends: - task: Npm@1 displayName: 'npm run test:copyresults' + condition: and(succeededOrFailed(), eq(variables['SetStartTest.startTest'], 'true')) inputs: command: custom workingDir: '${{ parameters.buildDirectory }}' From 43ebb690e17c207d2ab1d7b22dbfa023447e3c11 Mon Sep 17 00:00:00 2001 From: Daniel Madrid Date: Mon, 3 Mar 2025 14:24:46 -0800 Subject: [PATCH 4/8] startTest as parameter in include-test-task --- tools/pipelines/templates/build-npm-client-package.yml | 4 ++++ tools/pipelines/templates/build-npm-package.yml | 3 +++ tools/pipelines/templates/include-test-stability.yml | 3 +++ tools/pipelines/templates/include-test-task.yml | 8 ++++++-- 4 files changed, 16 insertions(+), 2 deletions(-) diff --git a/tools/pipelines/templates/build-npm-client-package.yml b/tools/pipelines/templates/build-npm-client-package.yml index bf897917d5c3..c33d1ee4582d 100644 --- a/tools/pipelines/templates/build-npm-client-package.yml +++ b/tools/pipelines/templates/build-npm-client-package.yml @@ -599,6 +599,7 @@ extends: echo "##vso[task.setvariable variable=startTest;isOutput=true]true" name: SetStartTestCoverage displayName: Start Test + condition: succeeded() - ${{ each test in parameters.coverageTests }}: - template: /tools/pipelines/templates/include-test-task.yml@self @@ -606,6 +607,7 @@ extends: taskTestStep: '${{ test.name }}' buildDirectory: '${{ parameters.buildDirectory }}' testCoverage: '${{ parameters.testCoverage }}' + startTest: $[variables['SetStartTestCoverage.startTest']] - task: Npm@1 displayName: 'npm run test:copyresults' @@ -754,12 +756,14 @@ extends: echo "##vso[task.setvariable variable=startTest;isOutput=true]true" name: SetStartTest displayName: Start Test + condition: succeeded() - template: /tools/pipelines/templates/include-test-task.yml@self parameters: taskTestStep: '${{ test.name }}' buildDirectory: '${{ parameters.buildDirectory }}' testCoverage: 'false' + startTest: $[variables['SetStartTest.startTest']] - task: Npm@1 displayName: 'npm run test:copyresults' diff --git a/tools/pipelines/templates/build-npm-package.yml b/tools/pipelines/templates/build-npm-package.yml index c308fe9dfc14..60a75a602026 100644 --- a/tools/pipelines/templates/build-npm-package.yml +++ b/tools/pipelines/templates/build-npm-package.yml @@ -347,6 +347,8 @@ extends: - script: | echo "##vso[task.setvariable variable=startTest]true" displayName: Start Test + name: setStartTest + condition: succeeded() - ${{ each taskTestStep in parameters.taskTest }}: - template: /tools/pipelines/templates/include-test-task.yml@self @@ -358,6 +360,7 @@ extends: parameters.testCoverage, ne(variables['Build.Reason'], 'PullRequest') )}} + startTest: $[variables['setStartTest.startTest']] - ${{ if contains(convertToJson(parameters.taskTest), 'tinylicious') }}: - task: Bash@3 diff --git a/tools/pipelines/templates/include-test-stability.yml b/tools/pipelines/templates/include-test-stability.yml index a75df4ce84ec..b9f495527f37 100644 --- a/tools/pipelines/templates/include-test-stability.yml +++ b/tools/pipelines/templates/include-test-stability.yml @@ -109,6 +109,8 @@ jobs: - script: | echo "##vso[task.setvariable variable=startTest]true" displayName: Start Test + name: setStartTest + condition: succeeded() - ${{ each taskTestStep in parameters.taskTest }}: - template: /tools/pipelines/templates/include-test-task.yml@self @@ -116,6 +118,7 @@ jobs: taskTestStep: ${{ taskTestStep }} buildDirectory: ${{ parameters.buildDirectory }} testCoverage: ${{ eq(variables['testCoverage'], true) }} + startTest: $[variables['setStartTest.startTest']] # Verify if the tinylicious log exists - task: Bash@3 diff --git a/tools/pipelines/templates/include-test-task.yml b/tools/pipelines/templates/include-test-task.yml index c4a4aa64adec..f010604bb65c 100644 --- a/tools/pipelines/templates/include-test-task.yml +++ b/tools/pipelines/templates/include-test-task.yml @@ -14,6 +14,10 @@ parameters: type: boolean default: false +- name: startTest + type: boolean + default: false + steps: # Test - With coverage - ${{ if and(parameters.testCoverage, startsWith(parameters.taskTestStep, 'ci:test')) }}: @@ -23,7 +27,7 @@ steps: command: 'custom' workingDir: ${{ parameters.buildDirectory }} customCommand: 'run ${{ parameters.taskTestStep }}:coverage' - condition: and(succeededOrFailed(), eq(variables['startTest'], 'true')) + condition: and(succeededOrFailed(), eq(${{ parameters.startTest }}, 'true')) env: # Tests can use this environment variable to behave differently when running from a test branch ${{ if contains(parameters.taskTestStep, 'tinylicious') }}: @@ -39,7 +43,7 @@ steps: command: 'custom' workingDir: ${{ parameters.buildDirectory }} customCommand: 'run ${{ parameters.taskTestStep }}' - condition: and(succeededOrFailed(), eq(variables['startTest'], 'true')) + condition: and(succeededOrFailed(), eq(${{ parameters.startTest }}, 'true')) env: # Tests can use this environment variable to behave differently when running from a test branch ${{ if contains(parameters.taskTestStep, 'tinylicious') }}: From faddebedad3203ef7dec292903f50ed4b6a1788a Mon Sep 17 00:00:00 2001 From: Daniel Madrid Date: Mon, 3 Mar 2025 14:31:13 -0800 Subject: [PATCH 5/8] nit --- tools/pipelines/templates/build-npm-client-package.yml | 8 ++++---- tools/pipelines/templates/build-npm-package.yml | 2 +- tools/pipelines/templates/include-test-stability.yml | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/pipelines/templates/build-npm-client-package.yml b/tools/pipelines/templates/build-npm-client-package.yml index c33d1ee4582d..8154e38d63f4 100644 --- a/tools/pipelines/templates/build-npm-client-package.yml +++ b/tools/pipelines/templates/build-npm-client-package.yml @@ -597,7 +597,7 @@ extends: # so that the steps to process/upload test coverage results only run if we got to the point of actually running tests. - script: | echo "##vso[task.setvariable variable=startTest;isOutput=true]true" - name: SetStartTestCoverage + name: setStartTestCoverage displayName: Start Test condition: succeeded() @@ -607,7 +607,7 @@ extends: taskTestStep: '${{ test.name }}' buildDirectory: '${{ parameters.buildDirectory }}' testCoverage: '${{ parameters.testCoverage }}' - startTest: $[variables['SetStartTestCoverage.startTest']] + startTest: eq($[variables['setStartTestCoverage.startTest']], 'true') - task: Npm@1 displayName: 'npm run test:copyresults' @@ -754,7 +754,7 @@ extends: # so that the steps to process/upload test coverage results only run if we got to the point of actually running tests. - script: | echo "##vso[task.setvariable variable=startTest;isOutput=true]true" - name: SetStartTest + name: setStartTest displayName: Start Test condition: succeeded() @@ -763,7 +763,7 @@ extends: taskTestStep: '${{ test.name }}' buildDirectory: '${{ parameters.buildDirectory }}' testCoverage: 'false' - startTest: $[variables['SetStartTest.startTest']] + startTest: eq($[variables['setStartTest.startTest']], 'true') - task: Npm@1 displayName: 'npm run test:copyresults' diff --git a/tools/pipelines/templates/build-npm-package.yml b/tools/pipelines/templates/build-npm-package.yml index 60a75a602026..b901788f1203 100644 --- a/tools/pipelines/templates/build-npm-package.yml +++ b/tools/pipelines/templates/build-npm-package.yml @@ -360,7 +360,7 @@ extends: parameters.testCoverage, ne(variables['Build.Reason'], 'PullRequest') )}} - startTest: $[variables['setStartTest.startTest']] + startTest: eq($[variables['setStartTest.startTest']], 'true') - ${{ if contains(convertToJson(parameters.taskTest), 'tinylicious') }}: - task: Bash@3 diff --git a/tools/pipelines/templates/include-test-stability.yml b/tools/pipelines/templates/include-test-stability.yml index b9f495527f37..b08ac30f7611 100644 --- a/tools/pipelines/templates/include-test-stability.yml +++ b/tools/pipelines/templates/include-test-stability.yml @@ -118,7 +118,7 @@ jobs: taskTestStep: ${{ taskTestStep }} buildDirectory: ${{ parameters.buildDirectory }} testCoverage: ${{ eq(variables['testCoverage'], true) }} - startTest: $[variables['setStartTest.startTest']] + startTest: eq($[variables['setStartTest.startTest']], 'true') # Verify if the tinylicious log exists - task: Bash@3 From bec242816fff3074d63fbfa48aa329dd55294390 Mon Sep 17 00:00:00 2001 From: Daniel Madrid Date: Mon, 3 Mar 2025 14:35:48 -0800 Subject: [PATCH 6/8] nit? --- tools/pipelines/templates/build-npm-client-package.yml | 4 ++-- tools/pipelines/templates/build-npm-package.yml | 2 +- tools/pipelines/templates/include-test-stability.yml | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/pipelines/templates/build-npm-client-package.yml b/tools/pipelines/templates/build-npm-client-package.yml index 8154e38d63f4..eaa118cb2a8a 100644 --- a/tools/pipelines/templates/build-npm-client-package.yml +++ b/tools/pipelines/templates/build-npm-client-package.yml @@ -607,7 +607,7 @@ extends: taskTestStep: '${{ test.name }}' buildDirectory: '${{ parameters.buildDirectory }}' testCoverage: '${{ parameters.testCoverage }}' - startTest: eq($[variables['setStartTestCoverage.startTest']], 'true') + startTest: $[eq(variables['setStartTestCoverage.startTest'], 'true')] - task: Npm@1 displayName: 'npm run test:copyresults' @@ -763,7 +763,7 @@ extends: taskTestStep: '${{ test.name }}' buildDirectory: '${{ parameters.buildDirectory }}' testCoverage: 'false' - startTest: eq($[variables['setStartTest.startTest']], 'true') + startTest: $[eq(variables['setStartTest.startTest'], 'true')] - task: Npm@1 displayName: 'npm run test:copyresults' diff --git a/tools/pipelines/templates/build-npm-package.yml b/tools/pipelines/templates/build-npm-package.yml index b901788f1203..2aa46e9f2cc2 100644 --- a/tools/pipelines/templates/build-npm-package.yml +++ b/tools/pipelines/templates/build-npm-package.yml @@ -360,7 +360,7 @@ extends: parameters.testCoverage, ne(variables['Build.Reason'], 'PullRequest') )}} - startTest: eq($[variables['setStartTest.startTest']], 'true') + startTest: $[eq(variables['setStartTest.startTest'], 'true')] - ${{ if contains(convertToJson(parameters.taskTest), 'tinylicious') }}: - task: Bash@3 diff --git a/tools/pipelines/templates/include-test-stability.yml b/tools/pipelines/templates/include-test-stability.yml index b08ac30f7611..5ed12fd22de0 100644 --- a/tools/pipelines/templates/include-test-stability.yml +++ b/tools/pipelines/templates/include-test-stability.yml @@ -118,7 +118,7 @@ jobs: taskTestStep: ${{ taskTestStep }} buildDirectory: ${{ parameters.buildDirectory }} testCoverage: ${{ eq(variables['testCoverage'], true) }} - startTest: eq($[variables['setStartTest.startTest']], 'true') + startTest: $[eq(variables['setStartTest.startTest'], 'true')] # Verify if the tinylicious log exists - task: Bash@3 From aeab00edb551f949a0a2c61c5e8f1f426ae968c9 Mon Sep 17 00:00:00 2001 From: Daniel Madrid Date: Mon, 3 Mar 2025 14:44:16 -0800 Subject: [PATCH 7/8] startTest as variable again --- tools/pipelines/templates/build-npm-client-package.yml | 4 +--- tools/pipelines/templates/build-npm-package.yml | 4 ++-- tools/pipelines/templates/include-test-stability.yml | 4 ++-- tools/pipelines/templates/include-test-task.yml | 8 ++------ 4 files changed, 7 insertions(+), 13 deletions(-) diff --git a/tools/pipelines/templates/build-npm-client-package.yml b/tools/pipelines/templates/build-npm-client-package.yml index eaa118cb2a8a..4bc8841bad2d 100644 --- a/tools/pipelines/templates/build-npm-client-package.yml +++ b/tools/pipelines/templates/build-npm-client-package.yml @@ -596,7 +596,7 @@ extends: # Set variable startTest if everything is good so far and we'll start running tests, # so that the steps to process/upload test coverage results only run if we got to the point of actually running tests. - script: | - echo "##vso[task.setvariable variable=startTest;isOutput=true]true" + echo "##vso[task.setvariable variable=startTestCoverage;isOutput=true]true" name: setStartTestCoverage displayName: Start Test condition: succeeded() @@ -607,7 +607,6 @@ extends: taskTestStep: '${{ test.name }}' buildDirectory: '${{ parameters.buildDirectory }}' testCoverage: '${{ parameters.testCoverage }}' - startTest: $[eq(variables['setStartTestCoverage.startTest'], 'true')] - task: Npm@1 displayName: 'npm run test:copyresults' @@ -763,7 +762,6 @@ extends: taskTestStep: '${{ test.name }}' buildDirectory: '${{ parameters.buildDirectory }}' testCoverage: 'false' - startTest: $[eq(variables['setStartTest.startTest'], 'true')] - task: Npm@1 displayName: 'npm run test:copyresults' diff --git a/tools/pipelines/templates/build-npm-package.yml b/tools/pipelines/templates/build-npm-package.yml index 2aa46e9f2cc2..1a3127253343 100644 --- a/tools/pipelines/templates/build-npm-package.yml +++ b/tools/pipelines/templates/build-npm-package.yml @@ -345,7 +345,8 @@ extends: - ${{ if ne(convertToJson(parameters.taskTest), '[]') }}: # Set variable startTest if the build succeed so that we can run all the test tasks whether they are failed or not - script: | - echo "##vso[task.setvariable variable=startTest]true" + echo "##vso[task.setvariable variable=startTest;isOutput=true]true" + echo "##vso[task.setvariable variable=startTestCoverage;isOutput=true]true" displayName: Start Test name: setStartTest condition: succeeded() @@ -360,7 +361,6 @@ extends: parameters.testCoverage, ne(variables['Build.Reason'], 'PullRequest') )}} - startTest: $[eq(variables['setStartTest.startTest'], 'true')] - ${{ if contains(convertToJson(parameters.taskTest), 'tinylicious') }}: - task: Bash@3 diff --git a/tools/pipelines/templates/include-test-stability.yml b/tools/pipelines/templates/include-test-stability.yml index 5ed12fd22de0..f35359b144fe 100644 --- a/tools/pipelines/templates/include-test-stability.yml +++ b/tools/pipelines/templates/include-test-stability.yml @@ -107,7 +107,8 @@ jobs: - ${{ if ne(convertToJson(parameters.taskTest), '[]') }}: # Set variable startTest if the build succeed so that we can run all the test tasks whether they are failed or not - script: | - echo "##vso[task.setvariable variable=startTest]true" + echo "##vso[task.setvariable variable=startTest;isOutput=true]true" + echo "##vso[task.setvariable variable=startTestCoverage;isOutput=true]true" displayName: Start Test name: setStartTest condition: succeeded() @@ -118,7 +119,6 @@ jobs: taskTestStep: ${{ taskTestStep }} buildDirectory: ${{ parameters.buildDirectory }} testCoverage: ${{ eq(variables['testCoverage'], true) }} - startTest: $[eq(variables['setStartTest.startTest'], 'true')] # Verify if the tinylicious log exists - task: Bash@3 diff --git a/tools/pipelines/templates/include-test-task.yml b/tools/pipelines/templates/include-test-task.yml index f010604bb65c..0bc8d52a2a96 100644 --- a/tools/pipelines/templates/include-test-task.yml +++ b/tools/pipelines/templates/include-test-task.yml @@ -14,10 +14,6 @@ parameters: type: boolean default: false -- name: startTest - type: boolean - default: false - steps: # Test - With coverage - ${{ if and(parameters.testCoverage, startsWith(parameters.taskTestStep, 'ci:test')) }}: @@ -27,7 +23,7 @@ steps: command: 'custom' workingDir: ${{ parameters.buildDirectory }} customCommand: 'run ${{ parameters.taskTestStep }}:coverage' - condition: and(succeededOrFailed(), eq(${{ parameters.startTest }}, 'true')) + condition: and(succeededOrFailed(), eq(variables['startTestCoverage'], 'true')) env: # Tests can use this environment variable to behave differently when running from a test branch ${{ if contains(parameters.taskTestStep, 'tinylicious') }}: @@ -43,7 +39,7 @@ steps: command: 'custom' workingDir: ${{ parameters.buildDirectory }} customCommand: 'run ${{ parameters.taskTestStep }}' - condition: and(succeededOrFailed(), eq(${{ parameters.startTest }}, 'true')) + condition: and(succeededOrFailed(), eq(variables['startTest'], 'true')) env: # Tests can use this environment variable to behave differently when running from a test branch ${{ if contains(parameters.taskTestStep, 'tinylicious') }}: From 174af5d9265770c2b531f050f5182dabbc7e19f2 Mon Sep 17 00:00:00 2001 From: Daniel Madrid Date: Mon, 3 Mar 2025 15:30:43 -0800 Subject: [PATCH 8/8] no isOutput --- .../templates/build-npm-client-package.yml | 14 +++++--------- tools/pipelines/templates/build-npm-package.yml | 6 ++---- .../pipelines/templates/include-test-stability.yml | 6 ++---- 3 files changed, 9 insertions(+), 17 deletions(-) diff --git a/tools/pipelines/templates/build-npm-client-package.yml b/tools/pipelines/templates/build-npm-client-package.yml index 4bc8841bad2d..5f12890ef324 100644 --- a/tools/pipelines/templates/build-npm-client-package.yml +++ b/tools/pipelines/templates/build-npm-client-package.yml @@ -596,10 +596,8 @@ extends: # Set variable startTest if everything is good so far and we'll start running tests, # so that the steps to process/upload test coverage results only run if we got to the point of actually running tests. - script: | - echo "##vso[task.setvariable variable=startTestCoverage;isOutput=true]true" - name: setStartTestCoverage + echo "##vso[task.setvariable variable=startTestCoverage]true" displayName: Start Test - condition: succeeded() - ${{ each test in parameters.coverageTests }}: - template: /tools/pipelines/templates/include-test-task.yml@self @@ -610,7 +608,7 @@ extends: - task: Npm@1 displayName: 'npm run test:copyresults' - condition: and(succeededOrFailed(), eq(variables['SetStartTestCoverage.startTest'], 'true')) + condition: and(succeededOrFailed(), eq(variables['startTestCoverage'], 'true')) inputs: command: custom workingDir: '${{ parameters.buildDirectory }}' @@ -622,7 +620,7 @@ extends: # A quick fix to patch the file with sed. (See https://github.com/bcoe/c8/issues/302) - task: Bash@3 displayName: Check for nyc/report directory - condition: and(succeededOrFailed(), eq(variables['startTest'], 'true')) + condition: and(succeededOrFailed(), eq(variables['startTestCoverage'], 'true')) inputs: targetType: 'inline' workingDirectory: '${{ parameters.buildDirectory }}' @@ -752,10 +750,8 @@ extends: # Set variable startTest if everything is good so far and we'll start running tests, # so that the steps to process/upload test coverage results only run if we got to the point of actually running tests. - script: | - echo "##vso[task.setvariable variable=startTest;isOutput=true]true" - name: setStartTest + echo "##vso[task.setvariable variable=startTest]true" displayName: Start Test - condition: succeeded() - template: /tools/pipelines/templates/include-test-task.yml@self parameters: @@ -765,7 +761,7 @@ extends: - task: Npm@1 displayName: 'npm run test:copyresults' - condition: and(succeededOrFailed(), eq(variables['SetStartTest.startTest'], 'true')) + condition: and(succeededOrFailed(), eq(variables['startTest'], 'true')) inputs: command: custom workingDir: '${{ parameters.buildDirectory }}' diff --git a/tools/pipelines/templates/build-npm-package.yml b/tools/pipelines/templates/build-npm-package.yml index 1a3127253343..b1b3de34ef03 100644 --- a/tools/pipelines/templates/build-npm-package.yml +++ b/tools/pipelines/templates/build-npm-package.yml @@ -345,11 +345,9 @@ extends: - ${{ if ne(convertToJson(parameters.taskTest), '[]') }}: # Set variable startTest if the build succeed so that we can run all the test tasks whether they are failed or not - script: | - echo "##vso[task.setvariable variable=startTest;isOutput=true]true" - echo "##vso[task.setvariable variable=startTestCoverage;isOutput=true]true" + echo "##vso[task.setvariable variable=startTest]true" + echo "##vso[task.setvariable variable=startTestCoverage]true" displayName: Start Test - name: setStartTest - condition: succeeded() - ${{ each taskTestStep in parameters.taskTest }}: - template: /tools/pipelines/templates/include-test-task.yml@self diff --git a/tools/pipelines/templates/include-test-stability.yml b/tools/pipelines/templates/include-test-stability.yml index f35359b144fe..19ec479f2796 100644 --- a/tools/pipelines/templates/include-test-stability.yml +++ b/tools/pipelines/templates/include-test-stability.yml @@ -107,11 +107,9 @@ jobs: - ${{ if ne(convertToJson(parameters.taskTest), '[]') }}: # Set variable startTest if the build succeed so that we can run all the test tasks whether they are failed or not - script: | - echo "##vso[task.setvariable variable=startTest;isOutput=true]true" - echo "##vso[task.setvariable variable=startTestCoverage;isOutput=true]true" + echo "##vso[task.setvariable variable=startTest]true" + echo "##vso[task.setvariable variable=startTestCoverage]true" displayName: Start Test - name: setStartTest - condition: succeeded() - ${{ each taskTestStep in parameters.taskTest }}: - template: /tools/pipelines/templates/include-test-task.yml@self