Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Typing issue with generated types causing Type X is not assignable to type Y #2052

Closed
MSNev opened this issue Apr 18, 2023 · 6 comments
Closed

[BUG] Typing issue with generated types causing Type X is not assignable to type Y #2052

MSNev opened this issue Apr 18, 2023 · 6 comments
Assignees
@MSNev
Labels
angular p1 react react-native released - NPM ts# compat Typescript version compatibility issue
Milestone
2.8.13

Comments

@MSNev
Copy link
Collaborator

MSNev commented Apr 18, 2023

With the generated type files created via the api-extractor, by including other application insights as "bundledTypes" can cause later versions of TypeScript to emit a Type XXX is not assignable to type YYY because it seems to consider the type included with the bundled versions doesn't match the direct version.

This has mostly occurred with
Type 'XXXX' is not assignable to type ITelemetryPlugin`
@MSNev MSNev self-assigned this Apr 18, 2023
@MSNev
Copy link
Collaborator Author

MSNev commented Apr 18, 2023

This needs to be fixed in both master and main

@MSNev MSNev added p1 ts# compat Typescript version compatibility issue react react-native angular labels Apr 18, 2023
@MSNev MSNev mentioned this issue Apr 18, 2023
Open
@MSNev MSNev modified the milestones: 2.x.x (Future), 2.8.13, 3.0.1 Apr 18, 2023
MSNev added a commit that referenced this issue Apr 18, 2023
@MSNev
[BUG] Typing issue with generated types causing Type X is not assigna…
fe68eab 
…ble to type Y #2052
MSNev added a commit that referenced this issue Apr 18, 2023
@MSNev
[BUG] Typing issue with generated types causing Type X is not assigna…
7919e2f 
…ble to type Y #2052
@MSNev
Copy link
Collaborator Author

MSNev commented Apr 19, 2023

#1678

@MSNev
Copy link
Collaborator Author

MSNev commented Apr 19, 2023

microsoft/applicationinsights-react-js#12

@MSNev
Copy link
Collaborator Author

MSNev commented Apr 19, 2023

microsoft/applicationinsights-angularplugin-js#97

@MSNev
Copy link
Collaborator Author

MSNev commented Apr 19, 2023

microsoft/applicationinsights-angularplugin-js#51

MSNev added a commit that referenced this issue Apr 19, 2023
@MSNev
[BUG] Typing issue with generated types causing Type X is not assigna…
388f676 
…ble to type Y #2052 (#2054)
MSNev added a commit that referenced this issue Apr 19, 2023
@MSNev
[BUG] Typing issue with generated types causing Type X is not assigna…
49fd4e9 
…ble to type Y #2052
MSNev added a commit that referenced this issue Apr 21, 2023
@MSNev
[BUG] Typing issue with generated types causing Type X is not assigna…
7ee34a3 
…ble to type Y #2052
MSNev added a commit that referenced this issue Apr 21, 2023
@MSNev
[BUG] Typing issue with generated types causing Type X is not assigna…
95b052d 
…ble to type Y #2052 (#2053)
@MSNev MSNev added the fixed - waiting release PR Committed and waiting deployment label Apr 21, 2023
@MSNev MSNev added released - NPM waiting - CDN deployment and removed fixed - waiting release PR Committed and waiting deployment labels May 1, 2023
@MSNev MSNev closed this as completed May 10, 2023
@github-actions GitHub Actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MSNev MSNev

Labels
angular p1 react react-native released - NPM ts# compat Typescript version compatibility issue
Projects
None yet
Milestone
2.8.13
Development

No branches or pull requests
1 participant
@MSNev