Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "X-Prometheus-Scrape-Timeout-Seconds" request header for timeouts #72

Open
Fra-nk opened this issue Jul 5, 2018 · 1 comment
Open

Use "X-Prometheus-Scrape-Timeout-Seconds" request header for timeouts #72

Fra-nk opened this issue Jul 5, 2018 · 1 comment

Comments

@Fra-nk
Copy link
Contributor

Fra-nk commented Jul 5, 2018

Prometheus already tells us, which time it allots for the query by supplying the header X-Prometheus-Scrape-Timeout-Seconds (which defaults to the global scrape timeout and can be overridden on a per-job basis).
Prometheus' default configuration sets 10 seconds.

Aligning --timeout with the X-Prometheus-Scrape-Timeout-Seconds would simplify the general setup.
@jpeach
Copy link
Contributor

jpeach commented Aug 17, 2018

Yep, we should pass the Prometheus scrape timeout along to the metrics snapshot timeout query parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpeach @Fra-nk