Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backbone.Subset does not correctly extend Backbone.Collection #14

Open
nthsense opened this issue Aug 27, 2013 · 0 comments
Open

Backbone.Subset does not correctly extend Backbone.Collection #14

nthsense opened this issue Aug 27, 2013 · 0 comments

Comments

@nthsense
Copy link

If you create a new instance of a Backbone.Subset, it does not act as an instance of a Backbone.Collection:

!(mySubset instanceof Backbone.Collection) === true

This is a problem because it means you can't always substitute a Subset for a Collection. Knockback, for instance, can't make a collectionObservable around a Subset because it does an instanceof safety check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant