Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event to create actual queries searched with #147

Open
gisostallenberg opened this issue Jun 12, 2020 · 1 comment
Open

Add event to create actual queries searched with #147

gisostallenberg opened this issue Jun 12, 2020 · 1 comment

Comments

@gisostallenberg
Copy link
Contributor

At the moment the queries are created as shown in the images below.
By dispatching an event that will create the queries, the bundle would become more flexible and it would for example allow to implement fuzzy queries, or anything more advanced.

Another way to allow more flexibility is to extract the search method of the adapter into two stages, creating the query prepareSearch and running it executeQuery. Extending the massive_search.adapter would be much easier that way.

image

image

@alexander-schranz
Copy link
Member

Events I think currently are difficult to handle at this case as they should not be adapter specific. I'm fine if we add some protected functions like prepareSearch and executeSearch into both adapters to make it easy to override this service functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants