Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.6 and MageRun2 #122

Closed
fballiano opened this issue Feb 18, 2025 · 4 comments
Closed

1.0.6 and MageRun2 #122

fballiano opened this issue Feb 18, 2025 · 4 comments

Comments

@fballiano
Copy link
Contributor

fballiano commented Feb 18, 2025

Everything is explained in this comment:
#115 (comment)

I'm opening this issue just not to forget about it.

@cmuench
Copy link
Contributor

cmuench commented Feb 18, 2025

@fballiano Currently we skip the compatibility check in Magerun. In the future I can add a logic in Magerun if something is incompatible.

The interesting code in Magerun is here: https://github.com/netz98/n98-magerun2/blob/8636430a8a990d581c1eeb7137b7681f79afd41b/src/N98/Magento/Application/Console/EventSubscriber/CheckCompatibility.php#L92

@cmuench
Copy link
Contributor

cmuench commented Feb 18, 2025

ok, we need a smaller change due to the new getDistributionName method.
I will also incease the minimum PHP version to 8.0 for the next n98-magerun2 release.

@cmuench
Copy link
Contributor

cmuench commented Feb 20, 2025

@fballiano I have merged some changes to the branch for the next n98-magerun2 release.
You can test this code by updating with n98-magerun2.phar self-update --unstable.

If everything works then you should see no compatibility issue anymore and the sys:info command should print the version number of the Mage-OS release and show the distribution name "Mage-OS".

@fballiano
Copy link
Contributor Author

tested and perfectly working, thank you so much @cmuench

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants