Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for modifying client settings on-the-fly #7760

Closed
ClobberXD opened this issue Sep 30, 2018 · 4 comments
Closed

Add support for modifying client settings on-the-fly #7760

ClobberXD opened this issue Sep 30, 2018 · 4 comments

Comments

@ClobberXD
Copy link
Contributor

ClobberXD commented Sep 30, 2018

Issue type
  • Feature request
Summary

Most other games, be they simple indie titles or the latest AAA titles, allow for changing settings in-game. It is quite boring and unnecessary to have to leave the server, just to adjust a couple of settings. This is especially pain-staking if leaving the server has significant negative effects. e.g. In CTF, a player's inventory is cleared on rejoin, and if one wants to adjust a setting, they'd have to wait till the match is over, which could occasionally take more than 2 hours.

It'd be very useful to be able to access the settings dialog from the pause menu itself, and once the user is done, they should be able to press an "Apply" button to apply all the modified settings on-the-go. Note that the suggested implementation is just an example, and needn't be the most suitable one for MT.

@SmallJoker
Copy link
Member

Duplicate of #6722, #6922, #3165 and probably more I couldn't find in this single search query.

@ClobberXD
Copy link
Contributor Author

Those issues are related, but aren't the same as this. The first two ask for a more detailed pause menu, and the third asks only for FOV modification on-the-fly. This feature request is about

  • The whole "Settings" menu (that's currently accessible from the main menu) to be accessible from the pause menu.
  • Some way to apply the modified settings on-the-fly

@SmallJoker
Copy link
Member

The entire settings menu (assuming you mean the Advanced Settings dialogue) would not be needed for ingame on-the-fly configuration. Only Graphics, Sound and Client would be suited for this task because even in singleplayer the server would not reload the configuration file unless you tell it to do so.
For speed reasons (yes, settings are slow) it's also a good choice to leave some settings cached and not allow changing them directly - reloading each second might be okay.

Taking the advanced settings menu into the game would either require to

  1. permanently allow CSMs (we have a restriction for that)
  2. or create a new Lua instance which is limited to this feature

Out of the left over configuration possibilities, this comment covers pretty much of it. This issue is just another suggestion on how to implement #6722 properly. Please add your suggestion there.

@ClobberXD
Copy link
Contributor Author

Only Graphics, Sound and Client would be suited for this task because even in singleplayer the server would not reload the configuration file unless you tell it to do so.

Ah ok, thanks for clarifying. I did mean only those. Sorry for yet another dupe :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants