Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minetest.get_player_window_information's "touch_controls" option should be moved to an integer/string #15167

Closed
swagtoy opened this issue Sep 15, 2024 · 2 comments
Labels
Duplicate Unconfirmed bug Bug report that has not been confirmed to exist/be reproducible

Comments

@swagtoy
Copy link
Contributor

swagtoy commented Sep 15, 2024

Minetest version

Minetest 5.9.0

Operating system and version

Windows 11 The latest

Summary

I am opening this thread because I want to question this.

Specifically, I want to just axe the touch_controls key and just move to a new variable, simply because:

  • You can only really use one control method at a time. There would be:
    • Touch controls
    • Keyboard controls
    • Controller controls
    • VR controls
    • Neurolink
    • Xbox 360 Logitech Steering Wheel
  • Writing your own fallback would be easier anyway local is_touchy = (win.control_method == 2 or win.touch_controls)
  • It's so astonishingly new that I doubt anyone is using it yet
  • ..and anyone that IS using something from 5.9.0 probably wouldn't mind updating their code if we axed it.

I suggest removal because deprecation for something that was just added and is already quite niche is just going to look gross.

If this is approved, I will keep this issue up, but will very likely fix this myself since I'm already using said code to change a formspec I'm writing.

Steps to reproduce

  1. Use Xbox 360 Logitech Steering Wheel.
  2. Question your life decisions.
@swagtoy swagtoy added the Unconfirmed bug Bug report that has not been confirmed to exist/be reproducible label Sep 15, 2024
@rubenwardy
Copy link
Contributor

rubenwardy commented Sep 15, 2024

This is a duplicate of #12264

@rubenwardy rubenwardy closed this as not planned Won't fix, can't repro, duplicate, stale Sep 15, 2024
@swagtoy
Copy link
Contributor Author

swagtoy commented Sep 15, 2024

@rubenwardy Apologize, I never saw that issue. I'd say it's not 100% a duplicate, especially seeing your issue suggesting something different, however I'll actually contribute to your issue instead so it's fine. Appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Duplicate Unconfirmed bug Bug report that has not been confirmed to exist/be reproducible
Projects
None yet
Development

No branches or pull requests

2 participants