[mlir][DataLayoutInterface] no impl filterEntryForIdentifier(TargetDeviceSpecListRef entries,...)

[makslevental]

This decl has no impl here (or anywhere else).

I'm not clear on the semantics so I'm not sure what an impl should look like? Possibly

TargetDeviceSpecInterface
mlir::detail::filterEntryForIdentifier(TargetDeviceSpecListRef entries,
                                       StringAttr id) {
  const auto *it = llvm::find_if(entries, [id](TargetDeviceSpecInterface entry) {
    if (auto attr = dyn_cast<StringAttr>(entry.getSpecForIdentifier(id).getKey()))
      return attr == id;
    return false;
  });
  return it == entries.end() ? TargetDeviceSpecInterface() : *it;
}

but I'm not sure (I don't work with this interface often).

[llvmbot]

@llvm/issue-subscribers-mlir

Author: Maksim Levental (makslevental)

[This decl](https://github.com/llvm/llvm-project/blob/5c1752e368585e55c0335a7d7651fe43d42af282/mlir/include/mlir/Interfaces/DataLayoutInterfaces.h#L108-L111) has no impl [here](https://github.com/llvm/llvm-project/blob/9192367ad1af30c59d5b7adc0a099bd7e524e5dd/mlir/lib/Interfaces/DataLayoutInterfaces.cpp#L314-L323) (or anywhere else).

I'm not clear on the semantics so I'm not sure what an impl should look like? Possibly

TargetDeviceSpecInterface
mlir::detail::filterEntryForIdentifier(TargetDeviceSpecListRef entries,
                                       StringAttr id) {
  const auto *it = llvm::find_if(entries, [id](TargetDeviceSpecInterface entry) {
    if (auto attr = dyn_cast<StringAttr>(entry.getSpecForIdentifier(id).getKey()))
      return attr == id;
    return false;
  });
  return it == entries.end() ? TargetDeviceSpecInterface() : *it;
}

but I'm not sure (I don't work with this interface often).

[gysit]

I am not super familiar with that code either.

TargetDeviceSpecInterface seems to use the signature of filterEntryForIdentifier that returns a DataLayoutEntryInterface. I am not sure if this intended or if an implementation similar to the one you suggested is needed.

@ftynse may know.