Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 8 compatibility #9

Closed
SteJaySulli opened this issue Jan 1, 2021 · 2 comments
Closed

Laravel 8 compatibility #9

SteJaySulli opened this issue Jan 1, 2021 · 2 comments

Comments

@SteJaySulli
Copy link

This package is locked to guzzle v 6.x -- Laravel 8 now uses 7.x; there are breaking changes as listed here.

It's also worth noting that guzzle 7.x removes PHP 5 support, and more importantly sets the minimum PHP version to 7.2 -- I have seen dependent packages (laravel-addresses for one) that have the minimum set to 7.1, so upgrading could cause breaking changes for legacy software running on PHP 7.1.

I will look further into this when I get the chance, but I've raised this issue so that it doesn't get forgotten and to welcome input from you other devs.

@DivineOmega
Copy link

Provision Laravel 8 compatibility added in this release: https://github.com/langleyfoxall/php-simple-google-maps/releases/tag/v1.2.0

Requires full tested. Please update this issue if you testing in Laravel 8 goes well or has problems.

@DivineOmega
Copy link

Closing under assumption this is fine. Create a new issue if there are problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants