Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to use CRD's without descriptions #6441

Open
terotuomala opened this issue Dec 23, 2024 · 0 comments
Open

Possibility to use CRD's without descriptions #6441

terotuomala opened this issue Dec 23, 2024 · 0 comments
Labels
feature-request All issues for new features that have not been committed to needs-discussion

Comments

@terotuomala
Copy link

terotuomala commented Dec 23, 2024

Proposal

Currently ScaledJob CRD can be applied only using kubectl apply --server-side ... because it is too long to process. In some cases using server-side apply is not feasible. Instead it should be possible to generate CRD's without description by using maxDescLen=0 option in https://github.com/kedacore/keda/blob/main/Makefile#L134.

I did some testing for crd-scaledjobs.yaml:

# With description

$ wc -c crd-scaledjobs.yaml
581688

# Description fields replaced with empty string

$ yq eval -i '(.. | select(has("description"))).description = ""' crd-scaledjobs.yaml
$ wc -c crd-scaledjobs.yaml
259711

Now it would not be mandatory to use server-side apply as the maximum size for metadata.annotations is 262144 bytes.

So I was wondering would it be possible to generate the CRD's without description also and e.g. add section to values.yaml to choose which one to use?

@terotuomala terotuomala added feature-request All issues for new features that have not been committed to needs-discussion labels Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request All issues for new features that have not been committed to needs-discussion
Projects
Status: To Triage
Development

No branches or pull requests

1 participant