Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement public close() method #33

Open
tomasfejfar opened this issue Jul 10, 2018 · 0 comments
Open

Implement public close() method #33

tomasfejfar opened this issue Jul 10, 2018 · 0 comments

Comments

@tomasfejfar
Copy link
Contributor

Because the method is not part of the public API and you need to explicitly dig into the source and it may lead to subtle bugs in some scenarios. And requires the developer to depend on potentially non-deterministic destruct behavior.

keboola/ex-email-attachments@e4d0217#r201359230
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomasfejfar