From 9b8a8fb5a393a8414fe6a1e0caf3748914583ba0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ond=C5=99ej=20Jodas?= Date: Sun, 2 Feb 2025 21:46:09 +0100 Subject: [PATCH] fix: add skipRegionValidation to test expectations --- src/Config/ConfigDefinition.php | 1 - tests/phpunit/ConfigTest.php | 8 +++++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/Config/ConfigDefinition.php b/src/Config/ConfigDefinition.php index 45d13dc..475ff92 100644 --- a/src/Config/ConfigDefinition.php +++ b/src/Config/ConfigDefinition.php @@ -106,7 +106,6 @@ protected function getParametersDefinition(): ArrayNodeDefinition ->scalarNode('#secret_access_key')->end() ->scalarNode('#bucket')->end() ->scalarNode('#jsonKey')->end() - ->scalarNode('region')->end() ->end() ; // @formatter:on diff --git a/tests/phpunit/ConfigTest.php b/tests/phpunit/ConfigTest.php index 9db0ee5..28dc9ab 100644 --- a/tests/phpunit/ConfigTest.php +++ b/tests/phpunit/ConfigTest.php @@ -107,6 +107,7 @@ public function validConfigDataProvider(): Generator ], [ 'storageBackendType' => Config::STORAGE_BACKEND_S3, + 'skipRegionValidation' => false, ], '.', false, @@ -133,6 +134,7 @@ public function validConfigDataProvider(): Generator '#secret_access_key' => 'testAccessKey', 'region' => 'testRegion', '#bucket' => 'testBucket', + 'skipRegionValidation' => false, ], '.', false, @@ -157,6 +159,7 @@ public function validConfigDataProvider(): Generator 'accountName' => 'testAccountName', '#accountKey' => 'testAccountKey', 'region' => 'testRegion', + 'skipRegionValidation' => false, ], '', false, @@ -186,6 +189,7 @@ public function validConfigDataProvider(): Generator '#secret_access_key' => 'testAccessKey', 'region' => 'testRegion', '#bucket' => 'testBucket', + 'skipRegionValidation' => false, ], '.', true, @@ -216,6 +220,7 @@ public function validConfigDataProvider(): Generator 'accountName' => 'testAccountName', '#accountKey' => 'testAccountKey', 'region' => 'testRegion', + 'skipRegionValidation' => false, ], 'testPath', true, @@ -247,7 +252,7 @@ public function validConfigDataProvider(): Generator 'region' => 'testRegion', '#bucket' => 'testBucket', 'backupPath' => 'testPath', - + 'skipRegionValidation' => false, ], 'testPath/', true, @@ -275,6 +280,7 @@ public function validConfigDataProvider(): Generator 'storageBackendType' => Config::STORAGE_BACKEND_ABS, 'accountName' => 'testAccountName', '#accountKey' => 'testAccountKey', + 'skipRegionValidation' => false, ], 'testPath', true,