From 663cb85e256606f535a77d5cbc5f8fbb4b7aa4a5 Mon Sep 17 00:00:00 2001 From: karthick-murugan Date: Fri, 24 Jan 2025 21:06:32 +0530 Subject: [PATCH] Feedback changes --- packages/block-library/src/quote/theme.scss | 2 +- test/e2e/specs/editor/various/patterns.spec.js | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/packages/block-library/src/quote/theme.scss b/packages/block-library/src/quote/theme.scss index 2c5983003986a1..24068d36b82e6c 100644 --- a/packages/block-library/src/quote/theme.scss +++ b/packages/block-library/src/quote/theme.scss @@ -21,7 +21,7 @@ border: none; padding-left: 0; } - // .is-style-large and .is-large are kept for backwards compatibility. + // .is-style-plain, .is-style-large and .is-large are kept for backwards compatibility. // They are not wrapped in `:where()` to keep specificity as it was before // they were deprecated. &:where(.is-style-plain), diff --git a/test/e2e/specs/editor/various/patterns.spec.js b/test/e2e/specs/editor/various/patterns.spec.js index ba9f851b4ed531..30dc71114b93f3 100644 --- a/test/e2e/specs/editor/various/patterns.spec.js +++ b/test/e2e/specs/editor/various/patterns.spec.js @@ -600,6 +600,15 @@ test.describe( 'Synced pattern', () => { editor.canvas.getByRole( 'document', { name: 'Block: Quote' } ) ); + // The quote block should have a visible preview in the sidebar for this test to be valid. + await expect( + page + .getByRole( 'region', { name: 'Editor settings' } ) + .getByRole( 'button', { name: 'Styles', exact: true } ) + ).toBeVisible(); + + await page.click( 'role=menuitem[name="Plain Style"i]' ); // Update the selector based on UI changes. + await editor.clickBlockOptionsMenuItem( 'Create pattern' ); const createPatternDialog = editor.page.getByRole( 'dialog', {