Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-Implement working NoParallelExecution #42

Closed
michaelschnyder opened this issue Apr 6, 2017 · 3 comments
Closed

Re-Implement working NoParallelExecution #42

michaelschnyder opened this issue Apr 6, 2017 · 3 comments

Comments

@michaelschnyder
Copy link
Member

michaelschnyder commented Apr 6, 2017

Applies to the following situation

Trigger has a Cron Definition of * * * * and a raises a jobrun at 12:00 which takes 5 mins.
Without NoParallelExecution, the trigger would again raise a jobRun at 12:01 even if the previous job did no complete.

-> NoParallelExecution does therefore prevent the trigger from triggering a new jobRun, but does not prevent other triggers from triggering a job.

@michaelschnyder
Copy link
Member Author

I suggest to rename this feature to PreventJobRunDublication or use an enum JobRunDublication with (Ignore, Prevent)

@olibanjoli

@olibanjoli
Copy link
Contributor

Duplication ;-)
Mhm I don't like the new name too much yet.

  • ParallelExecution is a widely used term which is clear to everyone
  • JobRunDuplication lacks the time component
  • "Duplication of job runs" is a bit off to me since the feature is about blocking running something in parallel.

I'm sure there is a better name than NoParallelExecution.

Maybe

  • DontTriggerIfPreviousDidNotFinish
  • WaitForPrevious
  • WaitForPreviousToFinish
  • DisableConcurrency

@michaelschnyder
Copy link
Member Author

So we decided to stick with this name for now, but have also discussed that we should extend the feature so that no other trigger (independent which type) can schedule a new run. Then it would be an update to the Job itself. See #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants