From cd3bf0ec3f280a8c8ef102a62ae192e75e5f9e40 Mon Sep 17 00:00:00 2001 From: George Kankava Date: Sat, 2 Jul 2016 18:25:36 +0400 Subject: [PATCH] squid:S1161 - '@Override' annotation should be used on any method overriding (since Java 5) or implementing (since Java 6) another one (#518) --- .../InfinispanProcessInstanceManager.java | 13 +++++++++++-- .../InfinispanProcessInstanceManagerFactory.java | 1 + .../processinstance/InfinispanSignalManager.java | 3 ++- .../InfinispanSignalManagerFactory.java | 1 + 4 files changed, 15 insertions(+), 3 deletions(-) diff --git a/kie-infinispan/jbpm-infinispan-persistence/src/main/java/org/jbpm/persistence/processinstance/InfinispanProcessInstanceManager.java b/kie-infinispan/jbpm-infinispan-persistence/src/main/java/org/jbpm/persistence/processinstance/InfinispanProcessInstanceManager.java index 16dffdd12f..a9020950b0 100644 --- a/kie-infinispan/jbpm-infinispan-persistence/src/main/java/org/jbpm/persistence/processinstance/InfinispanProcessInstanceManager.java +++ b/kie-infinispan/jbpm-infinispan-persistence/src/main/java/org/jbpm/persistence/processinstance/InfinispanProcessInstanceManager.java @@ -64,6 +64,7 @@ public void setKnowledgeRuntime(InternalKnowledgeRuntime kruntime) { this.kruntime = kruntime; } + @Override public void addProcessInstance(ProcessInstance processInstance, CorrelationKey correlationKey) { ProcessInstanceInfo processInstanceInfo = new ProcessInstanceInfo( processInstance, this.kruntime.getEnvironment() ); ProcessPersistenceContext context @@ -82,7 +83,8 @@ public void addProcessInstance(ProcessInstance processInstance, CorrelationKey c } internalAddProcessInstance(processInstance); } - + + @Override public void internalAddProcessInstance(ProcessInstance processInstance) { if( processInstances.putIfAbsent(processInstance.getId(), processInstance) != null ) { throw new ConcurrentModificationException( @@ -91,10 +93,12 @@ public void internalAddProcessInstance(ProcessInstance processInstance) { } } + @Override public ProcessInstance getProcessInstance(long id) { return getProcessInstance(id, false); } + @Override public ProcessInstance getProcessInstance(long id, boolean readOnly) { InternalRuntimeManager manager = (InternalRuntimeManager) kruntime.getEnvironment().get("RuntimeManager"); if (manager != null) { @@ -148,10 +152,12 @@ public ProcessInstance getProcessInstance(long id, boolean readOnly) { return processInstance; } + @Override public Collection getProcessInstances() { return Collections.unmodifiableCollection(processInstances.values()); } + @Override public void removeProcessInstance(ProcessInstance processInstance) { ProcessPersistenceContext context = ((ProcessPersistenceContextManager) this.kruntime.getEnvironment().get( EnvironmentName.PERSISTENCE_CONTEXT_MANAGER )).getProcessPersistenceContext(); ProcessInstanceInfo processInstanceInfo = context.findProcessInstanceInfo( processInstance.getId() ); @@ -162,16 +168,19 @@ public void removeProcessInstance(ProcessInstance processInstance) { internalRemoveProcessInstance(processInstance); } + @Override public void internalRemoveProcessInstance(ProcessInstance processInstance) { processInstances.remove( processInstance.getId() ); } - + + @Override public void clearProcessInstances() { /*for (ProcessInstance processInstance: new ArrayList(processInstances.values())) { ((ProcessInstanceImpl) processInstance).disconnect(); }*/ } + @Override public void clearProcessInstancesState() { try { // at this point only timers are considered as state that needs to be cleared diff --git a/kie-infinispan/jbpm-infinispan-persistence/src/main/java/org/jbpm/persistence/processinstance/InfinispanProcessInstanceManagerFactory.java b/kie-infinispan/jbpm-infinispan-persistence/src/main/java/org/jbpm/persistence/processinstance/InfinispanProcessInstanceManagerFactory.java index 18770da351..81ac73dae7 100644 --- a/kie-infinispan/jbpm-infinispan-persistence/src/main/java/org/jbpm/persistence/processinstance/InfinispanProcessInstanceManagerFactory.java +++ b/kie-infinispan/jbpm-infinispan-persistence/src/main/java/org/jbpm/persistence/processinstance/InfinispanProcessInstanceManagerFactory.java @@ -21,6 +21,7 @@ public class InfinispanProcessInstanceManagerFactory implements ProcessInstanceManagerFactory { + @Override public ProcessInstanceManager createProcessInstanceManager(InternalKnowledgeRuntime kruntime) { InfinispanProcessInstanceManager result = new InfinispanProcessInstanceManager(); result.setKnowledgeRuntime(kruntime); diff --git a/kie-infinispan/jbpm-infinispan-persistence/src/main/java/org/jbpm/persistence/processinstance/InfinispanSignalManager.java b/kie-infinispan/jbpm-infinispan-persistence/src/main/java/org/jbpm/persistence/processinstance/InfinispanSignalManager.java index faa7fc9f84..b76a1c01db 100644 --- a/kie-infinispan/jbpm-infinispan-persistence/src/main/java/org/jbpm/persistence/processinstance/InfinispanSignalManager.java +++ b/kie-infinispan/jbpm-infinispan-persistence/src/main/java/org/jbpm/persistence/processinstance/InfinispanSignalManager.java @@ -29,7 +29,8 @@ public class InfinispanSignalManager extends DefaultSignalManager { public InfinispanSignalManager(InternalKnowledgeRuntime kruntime) { super(kruntime); } - + + @Override public void signalEvent(String type, Object event) { for ( long id : getProcessInstancesForEvent( type ) ) { diff --git a/kie-infinispan/jbpm-infinispan-persistence/src/main/java/org/jbpm/persistence/processinstance/InfinispanSignalManagerFactory.java b/kie-infinispan/jbpm-infinispan-persistence/src/main/java/org/jbpm/persistence/processinstance/InfinispanSignalManagerFactory.java index 1ffdc793da..b101e7a5a8 100644 --- a/kie-infinispan/jbpm-infinispan-persistence/src/main/java/org/jbpm/persistence/processinstance/InfinispanSignalManagerFactory.java +++ b/kie-infinispan/jbpm-infinispan-persistence/src/main/java/org/jbpm/persistence/processinstance/InfinispanSignalManagerFactory.java @@ -21,6 +21,7 @@ public class InfinispanSignalManagerFactory implements SignalManagerFactory { + @Override public SignalManager createSignalManager(InternalKnowledgeRuntime kruntime) { return new InfinispanSignalManager(kruntime); }