From bc055569dfd9f3da08e40c104159ab3dc7d52c67 Mon Sep 17 00:00:00 2001 From: Nitin Srinivasan Date: Wed, 5 Feb 2025 08:26:38 -0800 Subject: [PATCH] Replace Python 3.12 with Python 3.13 and add Python 3.10 to the matrix Expands test coverage to cover the oldest and newest Python versions that we support. PiperOrigin-RevId: 723520699 --- .github/workflows/bazel_cpu_rbe.yml | 12 ++++++++++-- .github/workflows/bazel_cuda_rbe.yml | 12 ++++++++++-- 2 files changed, 20 insertions(+), 4 deletions(-) diff --git a/.github/workflows/bazel_cpu_rbe.yml b/.github/workflows/bazel_cpu_rbe.yml index d3e57eb906a9..d6816d492d1d 100644 --- a/.github/workflows/bazel_cpu_rbe.yml +++ b/.github/workflows/bazel_cpu_rbe.yml @@ -31,14 +31,22 @@ jobs: container: ${{ (contains(matrix.runner, 'linux-x86') && 'us-central1-docker.pkg.dev/tensorflow-sigs/tensorflow/ml-build:latest') || (contains(matrix.runner, 'linux-arm64') && 'us-central1-docker.pkg.dev/tensorflow-sigs/tensorflow/ml-build-arm64:latest') }} env: - JAXCI_HERMETIC_PYTHON_VERSION: "3.12" + JAXCI_HERMETIC_PYTHON_VERSION: ${{ matrix.python }} JAXCI_ENABLE_X64: ${{ matrix.enable-x_64 }} # Begin Presubmit Naming Check - name modification requires internal check to be updated strategy: matrix: + python: ["3.10", "3.13"] runner: ["linux-x86-n2-16", "linux-arm64-c4a-16"] enable-x_64: [1, 0] - name: "Bazel CPU tests (${{ matrix.runner }}, Python 3.12, x64=${{ matrix.enable-x_64 }})" + exclude: + # Exclude x64=1 on the oldest Python and x64=0 on the newest Python. As long as we have + # coverage for one of each, we don't need to run both. + - python: "3.10" + enable-x_64: 1 + - python: "3.13" + enable-x_64: 0 + name: "Bazel CPU tests (${{ matrix.runner }}, Python ${{ matrix.python }}, x64=${{ matrix.enable-x_64 }})" # End Presubmit Naming Check github-cpu-presubmits steps: - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 diff --git a/.github/workflows/bazel_cuda_rbe.yml b/.github/workflows/bazel_cuda_rbe.yml index 89f8147ee8ff..5a2c94c4db47 100644 --- a/.github/workflows/bazel_cuda_rbe.yml +++ b/.github/workflows/bazel_cuda_rbe.yml @@ -30,14 +30,22 @@ jobs: runs-on: ${{ matrix.runner }} container: 'us-central1-docker.pkg.dev/tensorflow-sigs/tensorflow/ml-build:latest' env: - JAXCI_HERMETIC_PYTHON_VERSION: "3.12" + JAXCI_HERMETIC_PYTHON_VERSION: ${{ matrix.python }} JAXCI_ENABLE_X64: ${{ matrix.enable-x_64 }} # Begin Presubmit Naming Check - name modification requires internal check to be updated strategy: matrix: + python: ["3.10", "3.13"] runner: ["linux-x86-n2-16"] enable-x_64: [1, 0] - name: "Bazel single accelerator CUDA tests (${{ matrix.runner }}, Python 3.12, x64=${{ matrix.enable-x_64 }})" + exclude: + # Exclude x64=1 on the oldest Python and x64=0 on the newest Python. As long as we have + # coverage for one of each, we don't need to run both. + - python: "3.10" + enable-x_64: 1 + - python: "3.13" + enable-x_64: 0 + name: "Bazel single accelerator CUDA tests (${{ matrix.runner }}, Python ${{ matrix.python }}, x64=${{ matrix.enable-x_64 }})" # End Presubmit Naming Check github-cuda-presubmits steps: - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2