You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It appears that if a class or classes already exist(s) on the svg element and 'inline-svgis called using theclass` parameter, these classes are replaced. It would make more sense to me that any additional classes are added. If classes need to be scrubbed from the SVG then it feels like that should happen in a transform, not as an unexpected bi-product of adding a class.
Additionally I need to add a class to all SVG elements. Obviously I could pass the same class every time I use inline-svg, but this feels like unnecessary repetition. I solved this by writing a transform that pulls a default class from config, but this would be a nice built-in config option.
The text was updated successfully, but these errors were encountered:
It would make more sense to me that any additional classes are added.
@Undistraction agreed. This feels like the correct behavior.
Obviously I could pass the same class every time I use inline-svg, but this feels like unnecessary repetition.
This would mean exposing the built-in transformations to the configure block, and allowing default values to be added. I'll have to think through the ramifications of this, as there's the potential for confusion here ("Where is this extra class coming from" etc.).
It appears that if a class or classes already exist(s) on the svg element and 'inline-svg
is called using the
class` parameter, these classes are replaced. It would make more sense to me that any additional classes are added. If classes need to be scrubbed from the SVG then it feels like that should happen in a transform, not as an unexpected bi-product of adding a class.Additionally I need to add a class to all SVG elements. Obviously I could pass the same class every time I use
inline-svg
, but this feels like unnecessary repetition. I solved this by writing a transform that pulls a default class from config, but this would be a nice built-in config option.The text was updated successfully, but these errors were encountered: