Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is there any plan to support these new Semi Theme in ThemeToggleButton ? #458

Open
dameng324 opened this issue Nov 2, 2024 · 4 comments
Open

Is there any plan to support these new Semi Theme in ThemeToggleButton ? #458

dameng324 opened this issue Nov 2, 2024 · 4 comments

Comments

@dameng324
Copy link
Contributor

Semi.Avalonia 12.2 introduced Aquatic, Desert, Dust, NightSky Themes.

But the ThemeToggleButton only switch between Default,Light,Dark. Is there any plan to support these new themes?
@rabbitism
Copy link
Member

We had an attempt in #418, but it's not working well.

@dameng324
Copy link
Contributor Author

Need help? How about adding a new property like AddtionalThemes ? Seems lower affect to old logic.

@rabbitism
Copy link
Member

事实上我们面对的问题是一个核心的功能决策：当目标ThemeScope的变化为ThemeSelector中没有的Theme时，ThemeSelctor应该处于什么状态。

@dameng324
Copy link
Contributor Author

Adding an unknown state will make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dameng324 @rabbitism