Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Codegen] RemoveSingleIterationLoop should use ValueBoundsOpInterface or similar #19626

Open
krzysz00 opened this issue Jan 7, 2025 · 1 comment
Assignees

Comments

@krzysz00
Copy link
Contributor

krzysz00 commented Jan 7, 2025

Currently, RemoveSingleIterationLoop is using a half-baked, homegrown bounds analysis to get minima and maxima for the arguments to affine expressions.

ValueBoundsOpInterface is already set up for this, we should use it.

@krzysz00 krzysz00 self-assigned this Jan 7, 2025
@krzysz00
Copy link
Contributor Author

krzysz00 commented Jan 7, 2025

I suspect, implicitly, that the pass that annotates GPU IDs with their bounds will need to be moved up before said loop iteration removal - or we could start doing such annotating in-place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant