Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] python-box 7.3.1 breaks netlab #1815

Closed
ipspace opened this issue Jan 15, 2025 · 1 comment
Closed

[BUG] python-box 7.3.1 breaks netlab #1815

ipspace opened this issue Jan 15, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@ipspace
Copy link
Owner

ipspace commented Jan 15, 2025

python-box release 7.3.1 completely breaks netlab, probably due to the change in how they handle "default box" parameter.

The root cause is probably a too-aggressive get somewhere in netlab code, but that might take a bit of time to figure out, so I pinned the python-box version required by netlab to less than 7.3.1 in af7ea2a.

@ipspace ipspace added the bug Something isn't working label Jan 15, 2025
@ipspace
Copy link
Owner Author

ipspace commented Jan 16, 2025

It looks like cdgriffith/Box#289 fixed the problem (thanks a million to @cdgriffith and @seb5g). Have to run a few more tests, but the CI tests pass with version 7.3.2 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant