Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] callbackUrl is not preserved #1902

Open
sidvishnoi opened this issue Jan 21, 2025 · 0 comments
Open

[BUG] callbackUrl is not preserved #1902

sidvishnoi opened this issue Jan 21, 2025 · 0 comments
Labels
bug Something isn't working triage Waiting to be assigned labels

Comments

@sidvishnoi
Copy link
Member

Steps to reproduce

  1. Go to https://wallet.interledger-test.dev/auth/login?callbackUrl=%2Fsettings%2Fdeveloper-keys
  2. Click on forgot password
  3. Cancel above
  4. Now login

Expected result

On login, user gets sent back to callbackUrl

Actual result

On login, user gets sent to / as callbackUrl got lost in navigations.

Screenshots or videos

No response

Additional context

In extension (during automatic key addition), we rely on user being on https://wallet.interledger-test.dev/settings/developer-keys page. If user on login doesn't get sent back to developer-keys page, extension's auto key-add process breaks (actually hangs, as it's waiting for user to be on developer-keys page).

Please preserve callbackUrl across any navigation once on login page, including:

  • after clicking forgot password email
  • canceling forgot password process
  • sign up

We could fix this in extension (making key-addition much more complex), but it's better suited here as it's better experience for users.

Operating system

Linux, macOS, Windows, iOS, Android

Operating system version

No response

Browsers

Chrome, Microsoft Edge, Firefox

Browser version

No response

@sidvishnoi sidvishnoi added bug Something isn't working triage Waiting to be assigned labels labels Jan 21, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Testnet Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Waiting to be assigned labels
Projects
Status: Backlog
Development

No branches or pull requests

1 participant