Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RoI ops for Torchvision #1290

Open
3 of 4 tasks
frost-intel opened this issue Jan 15, 2025 · 0 comments
Open
3 of 4 tasks

Add RoI ops for Torchvision #1290

frost-intel opened this issue Jan 15, 2025 · 0 comments

Comments

@frost-intel
Copy link
Contributor

frost-intel commented Jan 15, 2025

🚀 The feature, motivation and pitch

Currently, XPU supports torchvision::nms and torchvision::roi_align, but additional ops in the torchvision repo are not supported. My proposal is to add SYCL kernels for the following ops:

  • ps_roi_align
  • roi_pool
  • ps_roi_pool
  • deform_conv2d

Alternatives

No response

Additional context

No response

github-merge-queue bot pushed a commit that referenced this issue Jan 21, 2025
Adds SYCL kernels for `roi_pool`, `ps_roi_pool`, and `ps_roi_align` ops,
and registers them in torchvision. Code is adapted from existing CUDA
kernels, with minimal changes, similar to the existing `nms` and
`roi_align` ops.

Part of #1290 

### Testing
For testing, I copied the comprehensive ops [test
](https://github.com/pytorch/vision/blob/main/test/test_ops.py) from
torchvision repo. I removed the DefornConv test (support to come in a
follow-up PR) and autocast xpu tests, since autocast registration in
Pytorch would need to be updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant