Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid patient IDs when retrieving ThinkFast data #61

Open
ColinBD opened this issue Apr 1, 2021 · 1 comment
Open

Invalid patient IDs when retrieving ThinkFast data #61

ColinBD opened this issue Apr 1, 2021 · 1 comment
Labels
bug Oh my data-transfer Data Transfer Protocol

Comments

@ColinBD
Copy link
Contributor

ColinBD commented Apr 1, 2021

I am logging 9 patient IDs which fail validation but appear similar to valid IDs which makes me suspect these are the result of manual input errors when setting up a patient on the CANTAB and/or ThinkFast platforms. The IDs are shared in MS Teams.

I have setup a dictionary so that once we identify the typos/errors we can replace the invalid IDs during the validation process. Thus far we are confident making two corrections:

known_incorrect_ids = {'WRONG01':R-IGHT01', 'WRONG02': R-IGHT02'} 

We need to investigate the remaining 7 invalid IDs and then think about how we share this information.

@davidverweij
Copy link
Member

I'd argue that we would like to have the ability to inject / insert additional known 'oddities' to this list in the future as possible errors are made throughout the clinical study.

How about we create an additional MongoDB table where we can manually inject mappings if we uncover them. Then, if the pipeline would ever run again; it can automatically resolve the unresolved records (given it looks far enough back in time).

Having this as an injectable 'table' also allows us to develop additional features for the Clinician Facing app - where a user could report this error and mismatch and possibly automatically add the new 'oddity' to the list.

In any case, I would suggest to have the check for oddities as a final resort - after any lookup with ucam, inventory and even after checking its validity. Because, if a ID is wrong but valid - we can change this in UCAM and the DMP would still accept the entry and all is well. If it is edited wrongly and it is no longer valid ID; then we need to catch these in our middleware only.

@davidverweij davidverweij added bug Oh my data-transfer Data Transfer Protocol labels Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Oh my data-transfer Data Transfer Protocol
Projects
None yet
Development

No branches or pull requests

2 participants