Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Program dashboard: Fix donor file release counting #247

Open
kcullion opened this issue Feb 9, 2022 · 3 comments
Open

🐛 Program dashboard: Fix donor file release counting #247

kcullion opened this issue Feb 9, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@kcullion
Copy link

kcullion commented Feb 9, 2022

Describe the bug

I noticed in staging that the legacy ICGC programs have many files released into the file repository. But when looking at the donor dashboard, the "star" column in the table reflects no files have been released.

Related wiki: https://wiki.oicr.on.ca/display/icgcargotech/Program+Dashboard+Page+Specs

Steps To Reproduce

Compare the programs released donor counts to the dashboard:

  1. For example, look at PACA-CA in the file repository - there are 137 donors released with files
    image
  2. When you look at the program dashboard - it looks like just 136
    image
    image
  3. Other program counts are off too, like OCCAMS-GB. MUTO-INTL says 10 donors have released files but none are counted on the dashboard...

Expected behaviour

Double check that this column on the dashboard is showing the correct metrics for the donors and if they have files released - none, fully or partially

@kcullion kcullion added the bug Something isn't working label Feb 9, 2022
@lindaxiang
Copy link

@kcullion this may not be a bug.
According to the regulations, the files's donor have to submit all required clinical data so that they could be released. However for ICGC25k data, we implemented a walk around that all files are release before we receive their clinical data.

@kcullion
Copy link
Author

kcullion commented Feb 9, 2022

Thanks @lindaxiang ...perhaps we need to consolidate the rules for programs: new vs. legacy, and revisit this. I'll mark this as specs needed for now

@kcullion kcullion added the specs-needed Specs are needed for issue label Feb 9, 2022
@b-f-chan
Copy link

@Buwujiu - Will fix the implementation to match the rules as described

@b-f-chan b-f-chan removed the specs-needed Specs are needed for issue label May 31, 2022
@kcullion kcullion changed the title 🐛 Investigate dashboard donor file release counting 🐛 Program dashboard: Fix donor file release counting May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants