Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stopPort is now exclusive since 1.0.22 (Breaking change?) #89

Closed
yuchenshi opened this issue Aug 19, 2019 · 1 comment
Closed

stopPort is now exclusive since 1.0.22 (Breaking change?) #89

yuchenshi opened this issue Aug 19, 2019 · 1 comment

Comments

@yuchenshi
Copy link

Before, if stopPort is 9000, portfinder will try up to 9000 and see if it is open. With the new 1.0.22 release, portfinder seems to exclude 9000. This is seen in the code to generate candidatePorts, where it now reads i < options.stopPort instead of <=.

This is especially troublesome in firebase-tools, where we use the same port and stopPort (effectively only check if a single port number is open or not). The change in 1.0.22 completely broke firebase-tools where portfinder is used. See
firebase/firebase-tools#1606 (comment)

@eriktrom
Copy link
Member

this should be fixed, i rolled back v1.0.23 -> v1.0.21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants