Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Server Service Annotations Between Internal & Not #1087

Open
rfpludwick opened this issue Jan 24, 2025 · 0 comments
Open

Split Server Service Annotations Between Internal & Not #1087

rfpludwick opened this issue Jan 24, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@rfpludwick
Copy link

Is your feature request related to a problem? Please describe.

I am using external-dns to expose services in my k8s cluster to Pi-holes. Vault is one of those services. I am using the following YAML values for the Helm chart:

server:
  ingress:
    enabled: true
  service:
    annotations:
      external-dns.alpha.kubernetes.io/hostname: "vault.k8s-cluster.local"

This annotation is getting applied to both the vault-internal and vault services. It's causing issues with external-dns and is ending up setting the DNS to 10.* addresses, rather than the 192.168.* address I would be expecting.

Describe the solution you'd like

Feature request: please split the annotations which get applied to these two services, that way I can specify an annotation just for the vault service. Possible YAML values structure could be:

server:
  service:
    internal:
      annotations: {}
    external:
      annotations: {}

Describe alternatives you've considered

I've been unable to determine any alternative action I can take.

@rfpludwick rfpludwick added the enhancement New feature or request label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant