Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Extract CSS when bundling #1150

Open
2 of 7 tasks
jackw opened this issue Sep 30, 2024 · 0 comments
Open
2 of 7 tasks

Feat: Extract CSS when bundling #1150

jackw opened this issue Sep 30, 2024 · 0 comments
Labels
create-plugin related to the create-plugin tool enhancement New feature or request

Comments

@jackw
Copy link
Collaborator

jackw commented Sep 30, 2024

Which areas does this feature request relate to

  • Create Plugin
  • Sign Plugin
  • Plugin E2E
  • Plugin Meta Extractor
  • Documentation

Problem

Imported CSS files end up inlined in the JS bundles. This isn't an issue during development however for production builds this bloats the JS not only with CSS but also with the CSS source-map. There is also a security warning in the webpack docs related to using style-loader in production.

Solution

Use the mini-css-extract plugin to extract the imported css into .css files.

Alternatives

No response

Additional context

Are you interested in contributing the solution?

  • Yes
  • No
@jackw jackw added create-plugin related to the create-plugin tool enhancement New feature or request labels Sep 30, 2024
@jackw jackw self-assigned this Sep 30, 2024
@jackw jackw moved this from 📬 Triage to 🔬 In review in Plugins Platform / Grafana Community Sep 30, 2024
@github-actions github-actions bot added the stale label Dec 30, 2024
@jackw jackw removed their assignment Jan 8, 2025
@jackw jackw removed the stale label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-plugin related to the create-plugin tool enhancement New feature or request
Projects
Status: 📅 Planned
Development

Successfully merging a pull request may close this issue.

1 participant