New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Rendering deep flame graphs crashes on Firefox #342

Open

grafakus opened this issue Jan 23, 2025 · 0 comments

Labels

bug 🔥 flamegraph package

Contributor

grafakus commented Jan 23, 2025 •

edited

Loading

Bug description

Grafana version: 10.5.0
Plugin version: 0.1.17

The root cause of the error is that the canvas is too big for Firefox (online test).

As a workaround, the "Maximum number of nodes" setting can be adjusted to limit the depth of the flame graph (height of the canvas).

Steps to reproduce

Go to the AdHoc view
Upload a flame graph file with a very long call stack (todo: attach a file with non-sensitive data to this issue)

Actual behaviour

The flame graph does not render, a fatal error is displayed: "CanvasRenderingContext2D.fillText: Canvas is already in error state."

Expected behaviour

The flame graph should render

Additional notes

Check https://jhildenbiddle.github.io/canvas-size/ for a possible solution to the problem

grafakus added bug 🔥 flamegraph package labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment