Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate uses of Greedy Pattern Rewrite Driver #1221

Open
AlexanderViand-Intel opened this issue Dec 21, 2024 · 0 comments
Open

Investigate uses of Greedy Pattern Rewrite Driver #1221

AlexanderViand-Intel opened this issue Dec 21, 2024 · 0 comments

Comments

@AlexanderViand-Intel
Copy link
Collaborator

There have been two (somewhat) recent changes in the upstream rewrite drivers:

  1. The simpler Walk Pattern Rewrite Driver has been added for situations where the fixed point iteration of the greedy rewriter is not necessary
  2. The usual way to use the Greed Rewriter, applyPatternsAndFoldGreedily has been changed to applyPatternsGreedily with the decision on whether or not to also fold now configurable via the GreedyRewriteConfig parameter. Currently this defaults to still folding.

The TODO here is to investigate which of our passes that use the greedy rewrite driver can be dropped to a simple walk, and which applications of the greedy rewriter can have the folding dropped (and, e.g., moved to a later step in a pipeline).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant