-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable a faster backend for OpenFHE #1209
Comments
We patch in the openfhe config that would be generated by Cmake here: https://github.com/google/heir/blob/main/bazel/openfhe/add_config_core.patch First step is figuring out what the right generated header file is to replace that patch, then work through build issues. @ZenithalHourlyRate do you have a copy of the generated src/core/include/config_core.h that came with your faster build from #1195 ? |
I was just using $ cat build/src/core/config_core.h
//==================================================
// DO NOT TOUCH THIS FILE! It is generated by cmake
//==================================================
#ifndef __CMAKE_GENERATED_CONFIG_CORE_H__
#define __CMAKE_GENERATED_CONFIG_CORE_H__
/* #undef WITH_BE2 */
#define WITH_BE4
/* #undef WITH_NOISE_DEBUG */
/* #undef WITH_NTL */
/* #undef WITH_TCM */
#define CKKS_M_FACTOR 1
#define HAVE_INT128 TRUE
#define HAVE_INT64 TRUE
#define MATHBACKEND 4
#define NATIVEINT 64 I think the real problem is these lines heir/bazel/openfhe/openfhe.BUILD Lines 28 to 30 in 9031113
I tried to delete the |
I did a little more exploring - just deleting the OMP_NUM_THREADS=1 is not enough because we need to pass the openmp copts and linkopts to to the bazel rules. I added these flags (rest of the diff omitted but the rules are updated with these new opts)
But now I'm getting a segfault running the example. I can't get a stacktrace or any info but I can identify that it's coming from |
Cf. #1195 for discussion of the impact. We will need to add OpenMP as a dependency.
The text was updated successfully, but these errors were encountered: