Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: update gopls version requirements as part of the Go toolchain release workflow #71113

Open
findleyr opened this issue Jan 3, 2025 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Milestone

Comments

@findleyr
Copy link
Member

findleyr commented Jan 3, 2025

In https://go.dev/cl/640035, we apparently added an iterator use in gopls that made it susceptible to #70035. Thankfully, this was caught due to our legacy Go version builders. (Aside: this is a use-case for legacy builders that I'd not considered; apart from verifying integration with older Go commands, they also confirm that our minimum toolchain version is adequate).

We'll fix this by updating our minimum toolchain version, but that begs the question: why don't we always update our toolchain requirement to point to the latest patch release? Could we update the Go release workflow to send a CL against gopls? By analogy, we update VS Code following a gopls release.

The only reason that I can think of not to do this is that it may cause users to download more toolchain versions, or cause more friction for users that don't have GOTOOLCHAIN=auto. But given the frequency that we release new gopls versions, this seems acceptable. Am I missing something?

CC @adonovan @h9jiang @dmitshur

@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jan 3, 2025
@gopherbot gopherbot added this to the Unreleased milestone Jan 3, 2025
@findleyr findleyr changed the title x/build: update gopls version requirements as part of the toolchain release workflow x/build: update gopls version requirements as part of the Go toolchain release workflow Jan 3, 2025
@dmitshur dmitshur added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Jan 3, 2025
@thediveo
Copy link
Contributor

thediveo commented Jan 5, 2025

might this conflict with, for instance, devcontainers where I want to have a well-defined tooling?

@seankhliao
Copy link
Member

The tooling requirements for your project and for gopls probably shouldn't be conflated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Projects
None yet
Development

No branches or pull requests

5 participants