Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: add audio/mp3 to DetectContentType #50375

Closed
InfoLibre opened this issue Dec 28, 2021 · 2 comments
Closed

net/http: add audio/mp3 to DetectContentType #50375

InfoLibre opened this issue Dec 28, 2021 · 2 comments
Labels
FeatureRequest Issues asking for a new feature that does not need a proposal. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
pkgsite/unplanned

Comments

@InfoLibre
Copy link

InfoLibre commented Dec 28, 2021 •
edited
Loading

What is the URL of the page with the issue?

https://pkg.go.dev/net/http#DetectContentType

What is your user agent?

Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:95.0) Gecko/20100101 Firefox/95.0

What did you do?

I used http.DetectContentType with this uploaded MP3 file (unzip it to test):

Bagdad cafe - I'm Calling you.mp3.zip

buff, err := file.Open()
head := make([]byte, 512)
_, err = buff.Read(head)
contentType = http.DetectContentType(head)

What did you expect to see?

audio/mpeg or audio/mp3

What did you see instead?

application/octet-stream (the MIME type of this file isn't recognized)

Could you add this MIME type to http.DetectContentType?
@gopherbot gopherbot added this to the pkgsite/unplanned milestone Dec 28, 2021
@seankhliao seankhliao changed the title x/pkgsite: pkg.go.dev/net/http net/http: add audio/mp3 to DetectContentType Dec 28, 2021
@seankhliao seankhliao added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. and removed pkgsite labels Dec 28, 2021
@dmitshur dmitshur added the FeatureRequest Issues asking for a new feature that does not need a proposal. label Dec 28, 2021
@ALTree
Copy link
Member

ALTree commented Dec 29, 2021

It's already implemented, I think. Assuming your mp3 doesn't have ID3 in the first 512 bytes, this is #21124.

@seankhliao
Copy link
Member

Duplicate of #21124

@seankhliao seankhliao marked this as a duplicate of #21124 Nov 28, 2024
@seankhliao seankhliao closed this as not planned Won't fix, can't repro, duplicate, stale Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FeatureRequest Issues asking for a new feature that does not need a proposal. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
pkgsite/unplanned
Development

No branches or pull requests
5 participants
@dmitshur @ALTree @InfoLibre @gopherbot @seankhliao