Skip to content
This repository has been archived by the owner on Oct 28, 2019. It is now read-only.

Incompatible with Firefox 50 #421

Open
slyscorpion opened this issue Nov 16, 2016 · 11 comments
Open

Incompatible with Firefox 50 #421

slyscorpion opened this issue Nov 16, 2016 · 11 comments

Comments

@slyscorpion
Copy link

Hi folks,

Just wanted to let you know that this theme is incompatible with Firefox 50.
screenshot from 2016-11-16 01-44-33

@ghost
Copy link

ghost commented Nov 16, 2016

Duplicate of so many issues, see #410

@Omar007
Copy link

Omar007 commented Nov 17, 2016

That fix seems no longer sufficient. I had set mine to 99.0 since it broke with Firefox 48, but since I updated to Firefox 50, the firefox menu does no longer function and the menu layout is messed up.
Sadly I could not take a screenshot as the menu closes as soon as I take one :/

@jhasse
Copy link

jhasse commented Nov 18, 2016

Here's a screenshot:

firefox

@dyskette
Copy link

@jhasse See this comment.

In firefox 50 the options menu is restored by renaming panelUIOverlay.css to panelUI.css (it's in theme/shared/browser/customizableui)

@Omar007
Copy link

Omar007 commented Nov 18, 2016

I can confirm that does indeed fix it.

If you want to edit the file in the XPI directly, the path for it inside the XPI is:
./chrome-45/browser/customizableui

@jhasse
Copy link

jhasse commented Nov 18, 2016

For me it was ./chrome-46/browser/customizableui/ in the file ~/.mozilla/firefox/aw3etoyh.default/extensions/[email protected]. (I'm using https://addons.mozilla.org/de/firefox/addon/gnome-linux-only/)

It would be great if the version here could be updated: https://addons.mozilla.org/de/firefox/addon/adwaita/

@ghost
Copy link

ghost commented Nov 20, 2016

Well @jhasse, the authors of this addon seem to have lost interest. I don't why. Did they stop using Firefox? Did they stop using Gnome3?

@smichel17
Copy link

@jeroenpraat Read #410 (comment)

Also, this issue should probably be closed as a duplicate of #410. Having the same conversation in multiple places just makes information harder to find later.

@linuxundich
Copy link

Here's a (inofficial) updated version: https://addons.mozilla.org/en-Us/firefox/addon/gnome-3-updated

@ghost
Copy link

ghost commented May 28, 2017

That updated theme now also has some problems, like video controls that are broken. I really don't understand why this theme is abandoned. Especially now Canonical is switching to Gnome 3.*

@garrett
Copy link
Member

garrett commented Aug 8, 2017

@jeroenpraat: It's been mentioned several times that Firefox is removing native theme support, which makes this theme impossible. We were looking at adapting for the new Firefox, before photon was announced, but the changes landing in Firefox 57 will break that approach too.


You don't have to look any further than this same issue to see why it's really difficult to support the theme in Firefox:

  1. They change things every single release lately, breaking the theme.
  2. The quick release cycles mean we can't even get it reviewed and in the store before the next release or two is out.
  3. Mozilla announced deprecation of all full themes and old style extensions (forcing extensions to move to WebExtension... which isn't a bad thing overall, but we'll lose support for things we're doing in the extension as well as our backup plan for a CSS theme overlay).
  4. Firefox 57 will arrive soon and will force the full themes and old style extensions off. Only the background-wallpaper-as-a-so-called-theme "lightweight themes" and new style WebExtentions will be supported.

(I've written more details @ #410 (comment) before.)

Mozilla has promised to work on extending the lightweight themes, so we might be able to change things in a new version, when that lands. It might not (and probably will not, I'm guessing) by Firefox 57, when photon (the new UI) lands.

HOWEVER, this is not doom and gloom. The old legacy add-ons had all sorts of issues (security, stability, speed) that WebExtensions addresses. WebExtensions are intentionally mostly compatible with Chrome too, so this means developers only need to support 1 codebase (with possible minor changes) instead of 2 very different ones.

AND, to top it all off, when Firefox 57 lands, it'll feel much more at home on GNOME Desktops than previous versions. (There's still some room to go, but it won't stick out as a sore thumb as much.)

See #410 (comment) for more details about how Firefox 57 will look and how it (by default) fits in better with GNOME (still not perfect, but much better by default — the largest differences being the tabs-on-top and lack of client-side-decorations as well as no visual button borders... aside from that, it's actually mostly fine though).

I'm sure many of us here would like to tweak Firefox in the future (post-57), but not even Mozilla knows everything that will arrive then, so we can't target it quite yet. (The big stuff seems to have all landed, which is great news. Smaller things like client-side-decorations (aka: Firefox-managed-titlebar) on Linux might get pushed back a release or few, however.)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants