Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XNSE and XBOM special holiday 2024-01-22 #394

Open
npezolano opened this issue Jun 17, 2024 · 2 comments
Open

XNSE and XBOM special holiday 2024-01-22 #394

npezolano opened this issue Jun 17, 2024 · 2 comments
Labels
calendar update Calendar needs updating

Comments

@npezolano
Copy link

XNSE and XBOM had a special holiday and closed on Monday 2024-01-22 and a a result opened for trading on Saturday 2024-01-20

Currently its not showing 2024-01-22 as a holiday or 2024-01-20 as a trading day.

@magic-man
Copy link

@gerrymanoim This issue would be great to have implemented to avoid the need of having to manually correct this on the user's end.

@maread99
Copy link
Collaborator

Hi @npezolano, thanks for raising this. All changes to the calendars are user contributed, please see here on the README.

An ad-hoc change to the days of the week that an exchange can be open is a bit more complicated than usual holidays. It has been done on other calendars and I'd suggest anyone wanting to implement this change refer to the recent PR #376 which defined specific Saturdays as open on the XMOS calendar.

@maread99 maread99 added the calendar update Calendar needs updating label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
calendar update Calendar needs updating
Projects
None yet
Development

No branches or pull requests

3 participants