-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encoded files in alt are encoded again during alt update
#67
Comments
What versions of beets and beets-alternatives are you running? Re-encoding only happens when the plugin can't find the previously encoded files (or, when you change the target file format ( |
Looks like I'm using
No not as far as I know. I do sync the alt directory over Dropbox, but I tried running twice with Dropbox paused (just in case) and still see |
I guess I'm out of real ideas on what's going on here... a few things to try might be
|
On a MacBook Pro running Big Sur, so it's APFS. I guess the one quirk I know off the top of my head if the case insensitivity and I definitely have capitalized dir names in my paths ( On thing that's interesting running with verbose mode is that it looks like the mp3s are copying as well:
I don't know if you'd expect that log or not if the file is already there. Inspecting the directory, it does seem to be:
Also inspecting the alt library for something that's been converted:
|
Case-(in)sensitivity sounds like a plausible reason for this (although I don't yet see how exactly).
That's similar to the unexpected conversions; shouldn't happen if the file is already there and in the correct format.
Nothing suspicious here. You mentioned running |
Yeah, it feels like it could be a problem. Are you testing on Linux/Windows? If you point me in the right direction maybe there's some code we can try debugging on Mac to check out whether the "file already exists" logic has problems with the case.
Ok that makes me feel better. At least it's consistent.
If I do Downloading beets-alternatives-0.10.2.post1.tar.gz (10 kB)
.
.
.
Building wheels for collected packages: beets-alternatives
Building wheel for beets-alternatives (setup.py) ... done
Created wheel for beets-alternatives: filename=beets_alternatives-0.10.2.post1-py3-none-any.whl size=11042 sha256=0780de20ee99c65ccade736f8cf3c5a7ccbaa68b7ccbb2f6963cc9a1d63150f2 I omitted all the extra dependency checking in the output. Does that not look right? Sorry I've not done much python dev in my life so very much inexperienced when it comes to |
Yes, and there seem to be more problems on case-insensitive filesystems anyway: #66
Oh, that was probably due to #64; sorry for the fuss! |
When running
alt update
, files that have previously been encoded (by earlieralt update
runs) seem to be re-encoded. For instance, I've already run analt update
that included this version of Loveless but every time I run I see this again:I have a
alt
setup to convert to lossy formats from my lossless ones for my phone, and it seem to slow down and run through this encode step for every lossless track which means the process gets slower and slower every time I add an album in FLAC.My config looks like this:
The text was updated successfully, but these errors were encountered: