You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As discussed in #48, beets-alternatives crashes with a traceback if for some reason (most likely a bug in the plugin itself, or maybe due to a crashed alt update which wasn't committed to the database) the destination file/link already exists, but wasn't created by the plugin itself. This came up in the review comment #48 (comment) with respect to SymlinkViews, but probably equally affects External and ExternalConvert collections. Possible paths forward:
Keep everything as-is and crash, since this plugin always works under the assumption that the destination directory is exclusively managed by itself.
Same as above, but log a warning instead and skip the affected item (or abort cleanly?). Minimum viable option IMO, any kind of crash has the potential to disrupt consistency between filesystem and beets' database.
I’d go with 1) over 2). The main reason is that under these unexpected we want to notify the user early and visibly. We also want to avoid doing more work and potentially messing up things. As you rightfully pointed out we would need to ensure that the consistency is not worse than with 2).
However, I leave the decision between 1) and 2) up to you, @wisp3rwind.
As discussed in #48,
beets-alternatives
crashes with a traceback if for some reason (most likely a bug in the plugin itself, or maybe due to a crashedalt update
which wasn't committed to the database) the destination file/link already exists, but wasn't created by the plugin itself. This came up in the review comment #48 (comment) with respect toSymlinkView
s, but probably equally affectsExternal
andExternalConvert
collections. Possible paths forward:The text was updated successfully, but these errors were encountered: