-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It is not possible to install Riemann from a locally hosted package (TAR,RPM) #13
Comments
@noroute I'd certainly be more than happy to see either or both of these, I have other modules with a custom package install route. |
Simple approach to solve garethr#13. RPM/DEB-based approach is more difficult as paths differ between archive and packages.
I have a branch that makes the tar location configurable, as references above. I'm a bit reluctant to open a PR as I think the solution based on packages would be much better.
@garethr Would do you think? Especially about the path issues and backward compatibility. |
I think you could probably move most of the path issues into a param with a default value, and allow overing that in the init. That should remove the need for lots of duplication. I'm not too bothered about the compatibility of moving from one installation mechanism to the other, I think as long as the module defaults to doing as it does now that's fine. I'm maybe start small, by allowing overing the URL used to download Riemann. You could then work on swapping that with a package resource. I'm happy for that to leave the setup of package repos or building packages as an exercise for the user, which should minimise the cross-platform testing requirement. |
We have a branch mostly ready for this at Udacity, too. I just haven't had the bandwidth to wrap it up yet. |
As a side note the quickstart guide says:
Which at first pass made me believe that the config management modules had the information on package installs. |
For many organizations it is not an option to download software from external sources upon host setup.
We'd like to be able to install Riemann from a locally hosted, reviewed, known-good version.
I could provide a PR to either parametrize the path to the TAR to be installed (simple) or provide an installation from proper RPMs (more intrusive).
Would anyone be interested in any of these?
The text was updated successfully, but these errors were encountered: