Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would like to use --fast_moe but the v2.5.0 image is missing the acceleration plugin moe #457

Open
VassilisVassiliadis opened this issue Feb 6, 2025 · 1 comment

Comments

@VassilisVassiliadis
Copy link
Contributor

Is your feature request related to a problem? Please describe.

We would like to use --fast_moe but that commandline parameter requires the "moe" acceleration plugin (

fast_moe: Annotated[
FastMoe,
ConfigAnnotation(
path="training.moe",
key="scattermoe",
standalone=True,
experimental=True,
required_packages=["moe"],
),
).

However, the moe plugin is not in the 2.5.0 image:

RUN if [[ "${ENABLE_FMS_ACCELERATION}" == "true" ]]; then \
python -m pip install --user "$(head bdist_name)[fms-accel]"; \
python -m fms_acceleration.cli install fms_acceleration_peft; \
python -m fms_acceleration.cli install fms_acceleration_foak; \
python -m fms_acceleration.cli install fms_acceleration_aadp; \
fi

Describe the solution you'd like

Install the moe plugin in the Dockerfile

Describe alternatives you've considered

  1. Build a custom image with support for --fast_moe. This is problematic because the community will not have access too it.

Additional context

@willmj
Copy link
Collaborator

willmj commented Feb 6, 2025

We also require a manual install of this dependency currently to use accelerated MoE, so will need to include this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants