You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have been reviewing the code in "fragmenter-0.8.0", specifically the "packer.ts" code. I note that hash values are calculated using the relative, normalized folder names and the actual files themselves using Hasha. Specifically, here:
However, I believe the relativePath should be "const relativePath = path.relative(baseDir, absolutePath)" (i.e. reverse order) to produce values like "SimObjects/AirPlanes/FlyByWire_A380_842/aircraft.cfg" rather than "../..", "../../..", etc.
Although, the existing method works, I suspect the intent of the code is not strictly being followed. I have tested the existing code using the "pack.test.ts" code are retrieved the stated hash values.
Can you double check?
Many thanks,
Peter
The text was updated successfully, but these errors were encountered:
Hi,
Thanks for making this code available on GitHub.
I have been reviewing the code in "fragmenter-0.8.0", specifically the "packer.ts" code. I note that hash values are calculated using the relative, normalized folder names and the actual files themselves using Hasha. Specifically, here:
However, I believe the relativePath should be "const relativePath = path.relative(baseDir, absolutePath)" (i.e. reverse order) to produce values like "SimObjects/AirPlanes/FlyByWire_A380_842/aircraft.cfg" rather than "../..", "../../..", etc.
Although, the existing method works, I suspect the intent of the code is not strictly being followed. I have tested the existing code using the "pack.test.ts" code are retrieved the stated hash values.
Can you double check?
Many thanks,
Peter
The text was updated successfully, but these errors were encountered: