Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytest/test_document_fuse exits with unsuccessful status if all tests are skipped #1575

Open
smcv opened this issue Jan 16, 2025 · 1 comment
Labels

Comments

@smcv
Copy link
Collaborator

smcv commented Jan 16, 2025

Operating System

Debian unstable

XDG Desktop Portal version

Git

XDG Desktop Portal version (Other)

1.19.1-24-g7928c83

Desktop Environment

Other

Desktop Environment (Other)

Minimal autobuilder environment

Expected Behavior

/dev/fuse is not available in a minimal autobuilder environment, so test_document_fuse.py should be skipped (which in Meson's default test protocol means exit status 77).

Current Behavior

pytest exits with status 5 as documented in https://docs.pytest.org/en/stable/reference/exit-codes.html, but this is not an exit status that Meson considers to be a skip.

Steps to Reproduce

meson test in a minimal chroot

Anything else we should know?

No response

@smcv smcv added the bug label Jan 16, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jan 16, 2025
@smcv
Copy link
Collaborator Author

smcv commented Jan 16, 2025

An easy way to reproduce this:

diff --git a/tests/test_document_fuse.py b/tests/test_document_fuse.py
index 29f9f26..ef88ce4 100644
--- a/tests/test_document_fuse.py
+++ b/tests/test_document_fuse.py
@@ -1290,6 +1290,8 @@ def run_bash(cmd):
     return proc.returncode == 0
 
 
+pytest.skip('no', allow_module_level=True)
+
 if not run_bash("fusermount3 --version"):
     pytest.skip("no fusermount3", allow_module_level=True)
 

smcv added a commit to smcv/xdg-desktop-portal that referenced this issue Jan 16, 2025
smcv added a commit to smcv/xdg-desktop-portal that referenced this issue Jan 16, 2025
smcv added a commit to smcv/xdg-desktop-portal that referenced this issue Jan 16, 2025
swick added a commit to swick/xdg-desktop-portal that referenced this issue Jan 17, 2025
swick added a commit to swick/xdg-desktop-portal that referenced this issue Jan 17, 2025
Meson and ginsttest-runner expect the Automake convention and will
report a failure instead of a skipped test otherwise.

Resolves: flatpak#1575
swick added a commit to swick/xdg-desktop-portal that referenced this issue Jan 17, 2025
Meson and ginsttest-runner expect the Automake convention and will
report a failure instead of a skipped test otherwise.

Resolves: flatpak#1575
swick added a commit to swick/xdg-desktop-portal that referenced this issue Jan 20, 2025
Meson and ginsttest-runner expect the Automake convention and will
report a failure instead of a skipped test otherwise.

Resolves: flatpak#1575
github-merge-queue bot pushed a commit that referenced this issue Jan 20, 2025
Meson and ginsttest-runner expect the Automake convention and will
report a failure instead of a skipped test otherwise.

Resolves: #1575
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Needs Triage
Development

Successfully merging a pull request may close this issue.

1 participant