Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move fesc to a transform #832

Open
christopherlovell opened this issue Feb 12, 2025 · 0 comments
Open

Move fesc to a transform #832

christopherlovell opened this issue Feb 12, 2025 · 0 comments

Comments

@christopherlovell
Copy link
Contributor

Currently fesc is a hard coded argument on a spectra generation, but in an abstract sense applying an escape fraction is just a scalar transformation of an array. We should change all fesc instances to an emission model Transform derived class. This will also allow the implementation of an fesc - 1 method, for obtaining the escaped and transmitted spectra, for example.

Will lead to breaking changes to all methods that currently use the fesc argument, but more flexibility going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant