Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All grid datasets should carry unyt strings as attributes. #598

Open
WillJRoper opened this issue May 2, 2024 · 1 comment
Open

All grid datasets should carry unyt strings as attributes. #598

WillJRoper opened this issue May 2, 2024 · 1 comment
Labels
grid Any issues pertaining to grids Units An issue/PR related to units

Comments

@WillJRoper
Copy link
Collaborator

In an extension to #530 every dataset in a grid file should contain units which we can then read and attach to a Grid. As it stands we assume erg / s / Hz for all luminosities but we could find ourselves in a different situation. If we carry the units this is explicit and can be more flexible in the future.

@WillJRoper WillJRoper added grid Any issues pertaining to grids Units An issue/PR related to units labels May 2, 2024
@WillJRoper
Copy link
Collaborator Author

The only missing ingredient here is units on spectra and lines in grids from cloudy. This is being implemented in the grids repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid Any issues pertaining to grids Units An issue/PR related to units
Projects
None yet
Development

No branches or pull requests

1 participant