Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to LineCollection object to create Spectra #377

Open
stephenmwilkins opened this issue Nov 6, 2023 · 5 comments
Open

Add method to LineCollection object to create Spectra #377

stephenmwilkins opened this issue Nov 6, 2023 · 5 comments
Assignees
Labels
Lines issues/PRs involving lines. line ratios etc. Spectra/SED Issues relating to spectra and sed objects

Comments

@stephenmwilkins
Copy link
Collaborator

It will be useful to be able to generate a line contribution spectrum from a LineCollection instance. This would allow us e.g. to create more appropriate spectra when downsampling or converting the wavelength grid.

@stephenmwilkins stephenmwilkins self-assigned this Nov 6, 2023
@WillJRoper WillJRoper added Spectra/SED Issues relating to spectra and sed objects Lines issues/PRs involving lines. line ratios etc. labels Dec 11, 2023
@WillJRoper
Copy link
Collaborator

@stephenmwilkins can you give more details as to what you mean? It's not clear to me what you are asking for.

@stephenmwilkins
Copy link
Collaborator Author

If you have the luminosities of a set of lines you should be able to create a spectrum just using those lines, assuming you know the wavelengths. To do this properly you need to assume some line width but in the default instance you can assume all the photons are in a single resolution element.

@WillJRoper
Copy link
Collaborator

So that's effectively just a scatter plot?

@stephenmwilkins
Copy link
Collaborator Author

You could represent it by a scatter plot (wavelength_i, luminosity_i) but what we want is an actual spectrum. Obviously (depending on the resolution) some resolution elements (bins) will have a contribution from more than one line.

@WillJRoper
Copy link
Collaborator

Ah ok, I'm with you now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lines issues/PRs involving lines. line ratios etc. Spectra/SED Issues relating to spectra and sed objects
Projects
None yet
Development

No branches or pull requests

2 participants