Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer store object should be shared among popup panels #58

Open
janodvarko opened this issue Mar 10, 2015 · 0 comments
Open

Layer store object should be shared among popup panels #58

janodvarko opened this issue Mar 10, 2015 · 0 comments

Comments

@janodvarko
Copy link
Member

Every popup panel has currently its own instance of the Store object (PixelPerfectStore). This is wrong since adding/removing a layer in another tab (and another Pixel Perfect popup window) doesn't update other popup windows. All popup windows (from the same domain as soon as issue #40 is fixed) should be properly updated.

The store is currently initialized in PixelPerfectPopup ctor, it should be probably done in PixelPerfectToolboxOverlay.togglePixelPerfectPopup when the first PPP (pixel perfect popup) is opened for the first time.

Honza

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant